dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Feb 2021
1:33 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-6402-hd_dev-pre-treatment-self-tests' into staging

Options
1:32 pm

qnguyen  (deleted user)

1:27 pm

Dara Navaei and Sean Nash

9:54 am

Sean Nash

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

9:48 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:47 am

Sean Nash

You can remove the else - no longer needed.

You can remove the else - no longer needed.

9:46 am

Sean Nash

These cases should be in same order as enum. POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So shou...

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?

9:41 am

Sean Nash

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

9:40 am

Sean Nash

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

9:36 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

9:34 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

9:34 am

Sean Nash

Position may be ok. Check dependencies though.

Position may be ok. Check dependencies though.

9:30 am

Sean Nash

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

9:27 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:26 am

Sean Nash

Why commented out?

Why commented out?

9:25 am

Sean Nash

Why did this file change?

Why did this file change?

9:24 am

Sean Nash

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

Friday 19 Feb 2021
8:48 am

Dara Navaei

DEN-5980 added a #define for disabling the CRC check comments

Options
    • -1
    • +1
    /firmware/.launches/DG.launch
    • -1
    • +1
    /firmware/App/DGCommon.h
1:34 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added water sample command handler

Options
    • -26
    • +141
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -5
    • +6
    /firmware/App/Services/SystemCommMessages.c
Wednesday 17 Feb 2021
8:29 pm

Dara Navaei

DEN-5980 added or removed some of the states

Options
    • -1
    • +1
    /firmware/.launches/DG.launch
    • -6
    • +6
    /firmware/App/Controllers/LoadCell.c
    • -10
    • +1
    /firmware/App/Controllers/LoadCell.h
    • -0
    • +1
    /firmware/App/DGCommon.h
    • -4
    • +6
    /firmware/App/Services/Reservoirs.c
10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

qnguyen  (deleted user)

This should be part of Non-Volatile Data Management code review. Dara Navaei has added them to the alarm table.

This should be part of Non-Volatile Data Management code review.
Dara Navaei has added them to the alarm table.

10:25 am

qnguyen  (deleted user)

These have been uncommented.

These have been uncommented.

9:25 am

Sean Nash

Why commented out?

Why commented out?

9:24 am

Sean Nash

Need to add these to end of alarm table below.

Need to add these to end of alarm table below.

Tuesday 16 Feb 2021
10:57 pm

Dara Navaei

DEN-5980 removed old calibration commands

Options
    • -1
    • +1
    /firmware/.launches/DG.launch
    • -0
    • +2
    /firmware/App/Modes/ModeInitPOST.c
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -27
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
10:56 pm

pmontazemi  (deleted user)

Friday 12 Feb 2021
1:18 pm

Quang Nguyen <qnguyen@diality.com>

DEN-6402: Fixed load cell tare reset between tare requests

Options
    • -1
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -25
    • +47
    /firmware/App/Services/PIControllers.c
12:38 pm

Dara Navaei

DEN-5980 added more commands to send and receive NV data

Options
    • -0
    • +9
    /firmware/.launches/DG.launch
    • -0
    • +6
    /firmware/App/Modes/ModeInitPOST.c
    • -4
    • +28
    /firmware/App/Services/SystemComm.c
    • -21
    • +315
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +29
    /firmware/App/Services/SystemCommMessages.h
    • -3
    • +7
    /firmware/App/Tasks/TaskGeneral.c
    • -1
    • +1
    /firmware/App/Tasks/TaskPriority.c