dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5963 worked on RO pump and the drain states of heat disinfect

    • -124
    • +6
    /firmware/App/Controllers/ROPump.c
    • -3
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +0
    /firmware/App/Services/PIControllers.h
DG-DEN-7091_Pre Treatment Mode
DG-DEN-7091_Pre Treatment Mode
DEN-7091: Changed startup active reservoir to 1

DEN-5963 changed the RO pump control scheme from pressure control to flow control

    • -10
    • +1
    /firmware/App/Controllers/LoadCell.h
    • -91
    • +161
    /firmware/App/Controllers/ROPump.c
    • -11
    • +11
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +0
    /firmware/App/Services/PIControllers.c
DEN-7091: Added filter flush progress data broadcast

Merge branch 'DEN-6402-hd_dev-pre-treatment-self-tests' into staging

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Why is this commented out?

Why is this commented out?

You can remove the else - no longer needed.

You can remove the else - no longer needed.

These cases should be in same order as enum. POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So shou...

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Why are all of these commented out?

Why are all of these commented out?

Why are all of these commented out?

Why are all of these commented out?

Position may be ok. Check dependencies though.

Position may be ok. Check dependencies though.

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

Why is this commented out?

Why is this commented out?

Why commented out?

Why commented out?

Why did this file change?

Why did this file change?

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

DEN-5980 added a #define for disabling the CRC check comments

DEN-7091: Added water sample command handler

    • -26
    • +141
    /firmware/App/Modes/ModeStandby.c
DEN-5980 added or removed some of the states

    • -10
    • +1
    /firmware/App/Controllers/LoadCell.h
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This should be part of Non-Volatile Data Management code review. Dara Navaei has added them to the alarm table.

This should be part of Non-Volatile Data Management code review.
Dara Navaei has added them to the alarm table.

These have been uncommented.

These have been uncommented.

Why commented out?

Why commented out?