Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 29 Mar 2021

10:38 am

Dara Navaei

More
1154e93
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 218 more DG-DEN-5980-1 DG-DEN-7091-1

DEN-5980 addressed code review comments

- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -1
- +10
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -0
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

10:36 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Sunday 28 Mar 2021

10:34 am

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

10:34 am

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

10:33 am

Dara Navaei

More
Re: DG-DEN-5980-1
replied to qnguyen (deleted user)

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

10:24 am

Dara Navaei

More
Re: DG-DEN-5980-1
replied to qnguyen (deleted user)

Done.

Done.

10:23 am

Dara Navaei

More
Re: DG-DEN-5980-1
replied to qnguyen (deleted user)

Done.

Done.

Saturday 27 Mar 2021

6:21 pm

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
commented on review

if we skip POST, do we want to execute RTC POST test and other POST tests?

if we skip POST, do we want to execute RTC POST test and other POST tests?

6:14 pm

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
commented on review

Revert line deletion.

Revert line deletion.

6:13 pm

qnguyen (deleted user)

More
Re: DG-DEN-5980-1
commented on review

Add break.

Add break.

12:26 pm

Dara Navaei

More
fd5c3cf
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more DG-DEN-5963-1

DEN-5963 worked on heat disinfect mode

- -6
- +8
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -1
- +1
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -38
- +37
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -88
- +175
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

12:07 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

I moved the function to above and before the actuators.

I moved the function to above and before the actuators.

12:06 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to qnguyen (deleted user)

Done.

Done.

12:03 pm

Dara Navaei

More
bbd5ac2
changed 11 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 218 more DG-DEN-5980-1 DG-DEN-7091-1 DG-DEN-5963-1

DEN-5980 merged staging and resolved the merge conflicts

- -19
- +17
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -0
- +42
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -40
- +63
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -3
- +6
/firmware/App/Services/AlarmMgmt.h
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.h
- -0
- +11
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -21
- +186
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -6
- +29
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h
- -1
- +1
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c
- -14
- +20
/firmware/App/Tasks/TaskPriority.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskPriority.c
- -0
- +2
/firmware/source/sys_main.c
- History
- Source
- Diff
/firmware/source/sys_main.c

Friday 26 Mar 2021

6:05 pm

Sean Nash

More
2704b39
changed 1 file
develop_1-24

Merge branch 'DEN-7091-pre-treatment-mode' into develop

- -1
- +1
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c

6:04 pm

Sean Nash

More
f1427d9
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 217 more DG-DEN-7091-1

DEN-7091: broadcast alarm condition clear when cleared with alarm.

- -1
- +2
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c

Thursday 25 Mar 2021

10:42 am

Sean Nash

More
Re: DG-DEN-5980-1
replied to Dara Navaei

Yes, jobs are added to queue from General Task and removed from queue from Background Task. Need queue operations to be protected.

Yes, jobs are added to queue from General Task and removed from queue from Background Task. Need queue operations to be protected.

Wednesday 24 Mar 2021

12:38 pm

Dara Navaei

More
12ee765
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 218 more DG-DEN-5980-1

DEN-5980 addressed code review comments

- -0
- +1
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -1
- +2
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c
- -2
- +2
/firmware/App/Tasks/TaskPriority.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskPriority.c
- -1
- +1
/firmware/source/sys_main.c
- History
- Source
- Diff
/firmware/source/sys_main.c

12:37 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for ...

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for that.

12:26 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

Done.

Done.

12:25 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

12:23 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

Changed them to NVDataMgmt NVDataMgmt.

Changed them to NVDataMgmt NVDataMgmt.

12:23 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

12:21 pm

Dara Navaei

More
Re: DG-DEN-5980-1
replied to Sean Nash

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-12 02:23 -0800