dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5980 addressed code review comments

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

Done.

Done.

Done.

Done.

if we skip POST, do we want to execute RTC POST test and other POST tests?

if we skip POST, do we want to execute RTC POST test and other POST tests?

Revert line deletion.

Revert line deletion.

Add break.

Add break.

DEN-5963 worked on heat disinfect mode

    • -88
    • +175
    /firmware/App/Modes/ModeHeatDisinfect.c
I moved the function to above and before the actuators.

I moved the function to above and before the actuators.

Done.

Done.

DEN-5980 merged staging and resolved the merge conflicts

    • -19
    • +17
    /firmware/App/Controllers/DrainPump.c
    • -0
    • +42
    /firmware/App/Controllers/Heaters.c
    • -40
    • +63
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +11
    /firmware/App/Services/SystemComm.c
    • -14
    • +20
    /firmware/App/Tasks/TaskPriority.c
Merge branch 'DEN-7091-pre-treatment-mode' into develop

DEN-7091: broadcast alarm condition clear when cleared with alarm.

Yes, jobs are added to queue from General Task and removed from queue from Background Task. Need queue operations to be protected.

Yes, jobs are added to queue from General Task and removed from queue from Background Task. Need queue operations to be protected.

DEN-5980 addressed code review comments

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for ...

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for that.

Done.

Done.

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

Changed them to NVDataMgmt NVDataMgmt.

Changed them to NVDataMgmt NVDataMgmt.

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.