dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 15 Apr 2021
10:38 am

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:48 am

Dara Navaei

Done.

Done.

8:46 am

Dara Navaei

I changed it to one line.

I changed it to one line.

Wednesday 14 Apr 2021
11:27 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added dialysate 1 liter avg conductivity check

Options
    • -11
    • +0
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +11
    /firmware/App/Controllers/ConductivitySensors.h
    • -0
    • +20
    /firmware/App/Modes/ModeFill.c
11:18 pm

Sean Nash

So this function looks a lot like the transition function in standby mode. So maybe standby mode could have a public function that resets all of the actuators and then the transition function in st...

So this function looks a lot like the transition function in standby mode. So maybe standby mode could have a public function that resets all of the actuators and then the transition function in standby mode could call that function (and your modes could also call that function instead of this one).

11:11 pm

Sean Nash

I think "full" should be changed to target volume reached. Review function header descriptions for any updates needed.

I think "full" should be changed to target volume reached. Review function header descriptions for any updates needed.

11:07 pm

Dara Navaei

Yes, the exact same function is used in heat disinfect and one will be used in chemical disinfect. Where do you suggest we should put them?

Yes, the exact same function is used in heat disinfect and one will be used in chemical disinfect. Where do you suggest we should put them?

11:05 pm

Sean Nash

Recommend making this variable name a little more descripting. Something like alarmDetectedPendingTrigger.

Recommend making this variable name a little more descripting. Something like alarmDetectedPendingTrigger.

11:02 pm

Sean Nash

This function has no inputs. It only sets variables. It never references any.

This function has no inputs. It only sets variables. It never references any.

11:00 pm

Sean Nash

Not necessary. Standby mode is going to set actuators on entry 50ms from here so why bother.

Not necessary. Standby mode is going to set actuators on entry 50ms from here so why bother.

10:53 pm

Sean Nash

Is this function something we can have just once somewhere? I feel like this same function is going to be in both disinfect modes and this flush mode.

Is this function something we can have just once somewhere? I feel like this same function is going to be in both disinfect modes and this flush mode.

10:44 pm

Sean Nash

I think this is actually a time stamp for when flush mode began - and you are using it to calculate total flush mode elapsed time. I would add the word "Start" to the end of the variable name and c...

I think this is actually a time stamp for when flush mode began - and you are using it to calculate total flush mode elapsed time. I would add the word "Start" to the end of the variable name and clarify the comment.
stateTimer below is likely also a starting time - so same comment.

10:40 pm

Sean Nash

Didn't these RO pump control changes happen a long time ago? Why are they showing up here as new changes?

Didn't these RO pump control changes happen a long time ago? Why are they showing up here as new changes?

10:39 pm

Sean Nash

Why did this change so much? This is for the initial PWM estimate, right?

Why did this change so much? This is for the initial PWM estimate, right?

10:35 pm

Sean Nash

When do you think we will have something for this? I thought I heard Blaine say he thought we could get RPM conversion close enough to re-implement check.

When do you think we will have something for this? I thought I heard Blaine say he thought we could get RPM conversion close enough to re-implement check.

10:19 pm

Sean Nash

Still too many () now. You can still have 2 Hz default publish time if you want - I just didn't like the arrangement. Should be more like ( 500 / TASK_PRIORITY_INTERVAL ) so it is clear that you wa...

Still too many () now. You can still have 2 Hz default publish time if you want - I just didn't like the arrangement. Should be more like ( 500 / TASK_PRIORITY_INTERVAL ) so it is clear that you want every 500 ms.

9:30 pm

Dara Navaei

Done.

Done.

9:29 pm

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -2
    • +2
    /firmware/App/Controllers/Heaters.h
    • -3
    • +5
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -4
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -15
    • +0
    /firmware/App/Services/Reservoirs.c
    • -2
    • +0
    /firmware/App/Services/Reservoirs.h
7:10 pm

Dara Navaei

Done.

Done.

7:09 pm

Dara Navaei

Done.

Done.

2:14 pm

qnguyen  (deleted user)

Each condition should be put in a parenthesis ().

Each condition should be put in a parenthesis ().

10:25 am

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -10
    • +9
    /firmware/App/Controllers/ROPump.c
    • -5
    • +3
    /firmware/App/Controllers/TemperatureSensors.c
    • -102
    • +104
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -5
    • +6
    /firmware/App/Modes/ModeStandby.c
    • -9
    • +6
    /firmware/App/Services/SystemCommMessages.c
10:24 am

Dara Navaei

Done.

Done.

10:14 am

Dara Navaei

This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.

This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.

10:13 am

Dara Navaei

I removed 2. If faster publish time is needed, it should be overridden via Dialin.

I removed 2. If faster publish time is needed, it should be overridden via Dialin.

10:12 am

Dara Navaei

Done.

Done.

10:11 am

Dara Navaei

Done.

Done.

10:10 am

Dara Navaei

This section has been uncommented.

This section has been uncommented.

9:21 am

Dara Navaei

Done.

Done.