dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Apr 2021
10:11 am

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -3
    • +5
    /firmware/App/Controllers/DrainPump.c
    • -20
    • +19
    /firmware/App/Controllers/Heaters.c
    • -1
    • +3
    /firmware/App/Controllers/Heaters.h
    • -0
    • +11
    /firmware/App/Controllers/LoadCell.h
    • -1
    • +12
    /firmware/App/Controllers/Pressures.h
    • -9
    • +0
    /firmware/App/Controllers/ROPump.c
    • -0
    • +15
    /firmware/App/DGCommon.h
    • -61
    • +60
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -91
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -0
    • +8
    /firmware/App/Services/Reservoirs.h
10:11 am

Dara Navaei

Done.

Done.

9:18 am

Dara Navaei

Done.

Done.

9:17 am

Dara Navaei

This is another way to be able to turn off the pump by just setting the RPM to 0.

This is another way to be able to turn off the pump by just setting the RPM to 0.

9:15 am

Dara Navaei

I added a build switch to ignore this part.

I added a build switch to ignore this part.

9:15 am

Dara Navaei

I added a build switch to ignore this part.

I added a build switch to ignore this part.

9:15 am

Dara Navaei

I added a build switch to ignore this part.

I added a build switch to ignore this part.

9:15 am

Dara Navaei

I added a TODO on top to explain that this part will be addressed once the drain pump RPM can be read reliably. I added a build switch to ignore this part.

I added a TODO on top to explain that this part will be addressed once the drain pump RPM can be read reliably. I added a build switch to ignore this part.

9:02 am

Dara Navaei

Done.

Done.

8:56 am

Dara Navaei

Done.

Done.

8:55 am

Dara Navaei

This is an and. I changed the comment.

This is an and. I changed the comment.

8:54 am

Dara Navaei

Done.

Done.

8:50 am

Dara Navaei

Done.

Done.

Thursday 15 Apr 2021
11:07 pm

qnguyen  (deleted user)

Recommend adding TRUE or FALSE to check explicitly. Apply to the rest of the file.

Recommend adding TRUE or FALSE to check explicitly. Apply to the rest of the file.

10:58 pm

qnguyen  (deleted user)

This should be a post-increment. Otherwise, it will never retry with MAX_ALLOWED_STATE_TRIALS = 1. Apply to the rest of the file.

This should be a post-increment. Otherwise, it will never retry with MAX_ALLOWED_STATE_TRIALS = 1.
Apply to the rest of the file.

10:48 pm

qnguyen  (deleted user)

Should this be an OR (according to the comment)?

Should this be an OR (according to the comment)?

10:43 pm

qnguyen  (deleted user)

Align the define value (for most of the define section).

Align the define value (for most of the define section).

10:42 pm

qnguyen  (deleted user)

Use SEC_PER_MIN to replace 60.

Use SEC_PER_MIN to replace 60.

12:45 pm

Dara Navaei

I changed the publish interval to 1 second. I also removed the extra parentheses.

I changed the publish interval to 1 second. I also removed the extra parentheses.

12:43 pm

Dara Navaei

I brought it back.

I brought it back.

12:40 pm

Dara Navaei

I set them explicitly.

I set them explicitly.

11:28 am

Dara Navaei

The minimum is not needed and I removed it.

The minimum is not needed and I removed it.

11:21 am

Dara Navaei

The alarm is different for each condition, so that explains what failed and in what state (i.e reservoir drain time out in drain R1 state)

The alarm is different for each condition, so that explains what failed and in what state (i.e reservoir drain time out in drain R1 state)

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.