dgfirmware

Clone Tools

Stats

Commits this week: 4
Total Committers: 17
Last Commit: 29 Apr
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Apr 2021
10:54 am

Dara Navaei

DEN-5963 addressed a code review comment

Options
    • -0
    • +2
    /firmware/App/Controllers/ROPump.c
    • -3
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -7
    • +7
    /firmware/App/Services/AlarmMgmt.c
10:54 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:48 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

qnguyen  (deleted user)

Should we refactor the name then? It looks like A1 goes with B1, and A2 goes with B2 with the current name.

Should we refactor the name then? It looks like A1 goes with B1, and A2 goes with B2 with the current name.

9:23 am

Dara Navaei

Done.

Done.

9:17 am

Sean Nash

Inputs are data looked at in this function (e.g. in an if statement). Outputs are data that are changed in this function.

Inputs are data looked at in this function (e.g. in an if statement). Outputs are data that are changed in this function.

9:14 am

Dara Navaei

Done.

Done.

9:11 am

Dara Navaei

These are the inputs that are changed in this function. Is this not right?

These are the inputs that are changed in this function. Is this not right?

9:10 am

Dara Navaei

Done.

Done.

9:09 am

Dara Navaei

Done.

Done.

9:08 am

Dara Navaei

Done.

Done.

9:06 am

Dara Navaei

This is for the initial estimation. This has changed during the revisit of the RO pump module.

This is for the initial estimation. This has changed during the revisit of the RO pump module.

9:02 am

Dara Navaei

I copied and pasted this module from heat disinfect.

I copied and pasted this module from heat disinfect.

8:45 am

Dara Navaei

Yes, they only have one temperature sensor per board.

Yes, they only have one temperature sensor per board.

Sunday 18 Apr 2021
10:55 pm

qnguyen  (deleted user)

Is load cell A1 with A2, and B1 with B2?

Is load cell A1 with A2, and B1 with B2?

4:22 pm

Dara Navaei

DEN-5963 addressed code review comments. Added heaters monitor

Options
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -4
    • +4
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/Fans.c
    • -55
    • +138
    /firmware/App/Controllers/Heaters.c
    • -9
    • +9
    /firmware/App/Controllers/ROPump.c
    • -26
    • +6
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -0
    • +3
    /firmware/App/DGCommon.h
    • -8
    • +123
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -1
    • +15
    /firmware/App/Services/Reservoirs.c
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.c
3:31 pm

Dara Navaei

I uncommented the code.

I uncommented the code.

11:38 am

Dara Navaei

The above code has been deleted.

The above code has been deleted.

11:37 am

Dara Navaei

Done.

Done.

11:25 am

Dara Navaei

I uncommented the code.

I uncommented the code.

11:25 am

Dara Navaei

I uncommented the code.

I uncommented the code.

11:21 am

Dara Navaei

Done.

Done.

11:18 am

Dara Navaei

Done.

Done.