dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Apr 2021
1:01 pm

Sean Nash

DEN-7605: Added function to get previous op mode.

Options
    • -0
    • +5
    /firmware/App/Modes/ModeFault.c
    • -0
    • +14
    /firmware/App/Modes/OperationModes.c
    • -0
    • +1
    /firmware/App/Modes/OperationModes.h
11:39 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Removed alarm data type and unused variable

Options
    • -1
    • +0
    /firmware/App/Controllers/DrainPump.c
    • -11
    • +0
    /firmware/App/Services/AlarmMgmt.h
11:00 am

qnguyen  (deleted user)

Fixed.

Fixed.

10:59 am

qnguyen  (deleted user)

Done.

Done.

10:59 am

qnguyen  (deleted user)

Fixed. Compared to target temperature set by HD.

Fixed. Compared to target temperature set by HD.

10:59 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code reviews

Options
    • -0
    • +13
    /firmware/App/Controllers/Heaters.c
    • -0
    • +2
    /firmware/App/Controllers/Heaters.h
    • -36
    • +33
    /firmware/App/Modes/ModeFill.c
10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:43 am

Sean Nash

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the...

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the BOOL to a value like 0x12345678, this condition would still pass).
So in this condition, we are deciding whether dialysate can be delivered to the reservoir. We would like to err on the side of not delivering to the reservoir (safer state). So we should form the condition in a way that conductivity and temperature ranges being good must be TRUE (1) in order to deliver dialysate to the reservoir. Any other value would result in coming out of dialysate delivery state which is the safer thing to do.

9:30 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

9:04 am

Sean Nash

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

Wednesday 28 Apr 2021
8:17 pm

qnguyen  (deleted user)

Fixed.

Fixed.

5:08 pm

Dara Navaei

Merged DEN-8030 chemical disinfect

Options
    • -4
    • +12
    /firmware/App/Controllers/Heaters.c
    • -14
    • +39
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +2
    /firmware/App/Modes/ModeRecirculate.c
    • -11
    • +0
    /firmware/App/Services/AlarmMgmt.h
4:09 pm

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
4:09 pm

Dara Navaei

DEN-8030 debugged and fixed UV reactors driver

Options
    • -0
    • +4
    /firmware/.launches/DG.launch
    • -11
    • +11
    /firmware/App/Controllers/UVReactors.c
    • -26
    • +26
    /firmware/DG.dil
    • -2
    • +4
    /firmware/DG.hcg
    • -0
    • +266
    /firmware/include/het.h
    • -0
    • +1936
    /firmware/source/het.c
    • -0
    • +31
    /firmware/source/notification.c
    • -1
    • +1
    /firmware/source/pinmux.c
    • -0
    • +2
    /firmware/source/sys_main.c
11:20 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code review

Options
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
10:47 am

pmontazemi  (deleted user)

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

Tuesday 27 Apr 2021
10:01 am

Dara Navaei

9:59 am

Dara Navaei

Merge branch 'DEN-7568-dg-hd_dev-dg-mode-flush' into staging

Options
Monday 26 Apr 2021
5:43 pm

Dara Navaei

DEN-7568 added reservoir check to heat disinfect

Options
    • -49
    • +43
    /firmware/App/Modes/ModeHeatDisinfect.c
4:33 pm

Dara Navaei

DEN-7568 tested mode flush

Options
    • -1
    • +1
    /firmware/.launches/DG.launch
    • -3
    • +7
    /firmware/App/Modes/ModeFlush.c
    • -0
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +14
    /firmware/App/Services/Reservoirs.c
    • -0
    • +1
    /firmware/App/Services/Reservoirs.h
3:28 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

Options
3:19 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Change flush line RO pump rate to 0.6

Options
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
11:05 am

qnguyen  (deleted user)

DG-DEN-7802_DG-DEV Dialysate Generation
DG-DEN-7802_DG-DEV Dialysate Generation
10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:17 am

Dara Navaei

DEN-7568 addressed code review comments

Options
    • -5
    • +12
    /firmware/App/Controllers/Heaters.c
    • -14
    • +39
    /firmware/App/Controllers/TemperatureSensors.c
    • -24
    • +24
    /firmware/App/Controllers/TemperatureSensors.h
    • -18
    • +22
    /firmware/App/Modes/ModeFlush.c
10:16 am

Dara Navaei

Done.

Done.

Sunday 25 Apr 2021
10:36 pm

qnguyen  (deleted user)

This struct needs doxygen comment on individual member.

This struct needs doxygen comment on individual member.

9:00 am

Dara Navaei

DEN-7568 added more states to flush mode

Options
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -81
    • +134
    /firmware/App/Modes/ModeFlush.c
Saturday 24 Apr 2021
11:04 am

Dara Navaei

Moved this function to the FaultMode.c.

Moved this function to the FaultMode.c.