dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8103: Added request to mode fault when alarm has fault property

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7605_HD DG Self Tests
DG-DEN-7605_HD DG Self Tests
DEN-7605: Added s/w faults for voltage monitor.

    • -28
    • +4
    /firmware/App/Controllers/Voltages.c
DEN-7605: Added transfer functions for monitored voltages.

    • -11
    • +17
    /firmware/App/Controllers/Voltages.c
    • -24
    • +24
    /firmware/App/Drivers/InternalADC.c
Fixed merge conflicts.

DEN-7605: Added function to get previous op mode.

    • -0
    • +14
    /firmware/App/Modes/OperationModes.c
DEN-7802: Removed alarm data type and unused variable

Fixed.

Fixed.

Done.

Done.

Fixed. Compared to target temperature set by HD.

Fixed. Compared to target temperature set by HD.

DEN-7802: Addressed code reviews

    • -0
    • +13
    /firmware/App/Controllers/Heaters.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the...

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the BOOL to a value like 0x12345678, this condition would still pass).
So in this condition, we are deciding whether dialysate can be delivered to the reservoir. We would like to err on the side of not delivering to the reservoir (safer state). So we should form the condition in a way that conductivity and temperature ranges being good must be TRUE (1) in order to deliver dialysate to the reservoir. Any other value would result in coming out of dialysate delivery state which is the safer thing to do.

Add blank line between declarations and code.

Add blank line between declarations and code.

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

Fixed.

Fixed.

Merged DEN-8030 chemical disinfect

    • -4
    • +12
    /firmware/App/Controllers/Heaters.c
Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

DEN-8030 debugged and fixed UV reactors driver

    • -11
    • +11
    /firmware/App/Controllers/UVReactors.c
    • -0
    • +1936
    /firmware/source/het.c
DEN-7802: Addressed code review

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

Merge branch 'DEN-7568-dg-hd_dev-dg-mode-flush' into staging

DEN-7568 added reservoir check to heat disinfect

    • -49
    • +43
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-7568 tested mode flush

    • -0
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +14
    /firmware/App/Services/Reservoirs.c
Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

DEN-7802: Change flush line RO pump rate to 0.6