dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 May 2021
10:09 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Enable water quality checks

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -0
    • +2
    /firmware/App/Modes/ModeStandby.c
Friday 21 May 2021
2:35 pm

Sean Nash

DEN-7605: Added tare state to drain mode to allow time for reservoir to settle first.

Options
    • -5
    • +45
    /firmware/App/Modes/ModeDrain.c
    • -7
    • +33
    /firmware/App/Services/Reservoirs.c
    • -1
    • +3
    /firmware/App/Services/Reservoirs.h
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -7
    • +7
    /firmware/App/Controllers/ROPump.c
10:20 am

Sean Nash

Fixed.

Fixed.

10:20 am

Sean Nash

Fixed.

Fixed.

9:18 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -2
    • +2
    /firmware/App/DGCommon.h
9:18 am

Sean Nash

Fixed merge conflicts.

Options
    • -0
    • +4
    /firmware/.launches/DG.launch
    • -4
    • +109
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +69
    /firmware/App/Controllers/ROPump.c
    • -8
    • +69
    /firmware/App/Controllers/Valves.c
    • -0
    • +1
    /firmware/App/Controllers/Valves.h
    • -2
    • +2
    /firmware/App/DGCommon.h
    • -6
    • +10
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +0
    /firmware/App/Modes/ModeStandby.c
8:54 am

Sean Nash

DEN-7605: Added delays to drain mode.

Options
    • -0
    • +12
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.h
    • -4
    • +10
    /firmware/App/Modes/ModeDrain.c
Thursday 20 May 2021
12:18 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Imposed maximum crc size

Options
    • -101
    • +2
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +130
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -2
    • +14
    /firmware/App/Services/FPGA.c
    • -0
    • +2
    /firmware/App/Services/FPGA.h
    • -25
    • +54
    /firmware/App/Services/Integrity.c
11:26 am

qnguyen  (deleted user)

The only preference is to put TRUE first if it is == such as below.

The only preference is to put TRUE first if it is == such as below.

8:58 am

Sean Nash

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

Wednesday 19 May 2021
6:33 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
5:15 pm

Sean Nash

Should we move this enum to separate .h file?

Should we move this enum to separate .h file?

4:54 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:35 pm

pmontazemi  (deleted user)

Place TRUE as first argument.

Place TRUE as first argument.

3:29 pm

pmontazemi  (deleted user)

If we align, we align everything, otherwise, no extra spaces between variables and the "=" sign.

If we align, we align everything, otherwise, no extra spaces between variables and the "=" sign.

3:28 pm

pmontazemi  (deleted user)

Align comment.

Align comment.

10:38 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Alarm when firmware image integrity check failed

Options
    • -1
    • +12
    /firmware/App/Services/Integrity.c
Tuesday 18 May 2021
10:33 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -2
    • +2
    /firmware/App/DGCommon.h
3:33 pm

Sean Nash

DEN-7605: Added options to valves and pumps to delay changes in state.

Options
    • -4
    • +97
    /firmware/App/Controllers/DrainPump.c
    • -0
    • +2
    /firmware/App/Controllers/DrainPump.h
    • -2
    • +69
    /firmware/App/Controllers/ROPump.c
    • -1
    • +2
    /firmware/App/Controllers/ROPump.h
    • -8
    • +69
    /firmware/App/Controllers/Valves.c
    • -0
    • +1
    /firmware/App/Controllers/Valves.h
10:07 am

qnguyen  (deleted user)

DG-DEN-8103_DG HD Dev Alarm Design
DG-DEN-8103_DG HD Dev Alarm Design
Monday 17 May 2021
3:57 pm

Sean Nash

DEN-7605: Initialize fluid leak override structure on power up.

Options
    • -0
    • +3
    /firmware/App/Controllers/FluidLeak.c
Saturday 15 May 2021
9:51 am

Dara Navaei

I thought we decided to pass the broadcast data as a reference. Did we change that?

I thought we decided to pass the broadcast data as a reference. Did we change that?

Friday 14 May 2021
5:14 pm

Dara Navaei

Merged DEN-8030_chemical disinfect

Options
5:12 pm

Dara Navaei

DEN-8030 fixed load cells tare

Options
    • -5
    • +5
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/DGCommon.h
3:20 pm

qnguyen  (deleted user)

Removed casting.

Removed casting.

3:19 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added fill mode paused state

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +6
    /firmware/App/Controllers/Heaters.c
    • -5
    • +3
    /firmware/App/Controllers/ROPump.c
    • -3
    • +41
    /firmware/App/Modes/ModeFill.c
3:18 pm

qnguyen  (deleted user)

The macro already cast the data to U32.

The macro already cast the data to U32.

1:43 pm

Sean Nash

Should maybe cast here though.

Should maybe cast here though.