Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 07 Jun 2021

11:41 pm

Quang Nguyen <qnguyen@diality.com>

More
bb1f2d0
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 212 more DG-DEN-8103-1

DEN-8103: Transition to fault mode if alarm is a DG fault alarm

- -2
- +2
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c

3:42 pm

Dara Navaei

More
fd3f3c6
changed 1 file
develop_1-24

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

3:42 pm

Sean Nash

More
f4c0fa9
changed 0 files
develop_1-24

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

3:42 pm

Sean Nash

More
6ea50f7
changed 1 file
develop_1-24

Fixed launch file to not erase whole flash.

- -26
- +4
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch

1:57 pm

Dara Navaei

More
da553c2
changed 1 file
develop_1-24

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

1:57 pm

Sean Nash

More
7df1fae
changed 8 files
develop_1-24

Fixed merge conflicts.

- -0
- +22
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -3
- +0
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -2
- +2
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -3
- +3
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -1
- +3
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -9
- +9
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -2
- +2
/firmware/App/Services/FPGA.h
- History
- Source
- Diff
/firmware/App/Services/FPGA.h
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

1:52 pm

Sean Nash

More
6043f64
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1

DEN-7605: Removed obsolete code.

- -3
- +0
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c

1:50 pm

Sean Nash

More
5f86e35
changed 7 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1 DG-DEN-8103-1

DEN-7605: Minor fixes.

- -0
- +16
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -2
- +2
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -5
- +5
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -1
- +3
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -9
- +9
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -2
- +2
/firmware/App/Services/FPGA.h
- History
- Source
- Diff
/firmware/App/Services/FPGA.h
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

Sunday 06 Jun 2021

6:13 pm

Dara Navaei

More
3f7d30b
changed 10 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8030-1

DEN-8030 added UI states to heat disinfect. Changed the heaters control.

- -0
- +7
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -3
- +10
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -19
- +48
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -3
- +0
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -4
- +5
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -0
- +2
/firmware/App/Modes/ModeChemicalDisinfect.h
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.h
- -6
- +33
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -0
- +2
/firmware/App/Modes/ModeHeatDisinfect.h
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.h
- -2
- +9
/firmware/App/Modes/ModeRecirculate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeRecirculate.c
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

Friday 04 Jun 2021

2:13 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Change order of comparison.

Change order of comparison.

2:11 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Blank line after declaration.

Blank line after declaration.

2:08 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo ch...

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo channel and TRo can just be a copy of TDi for now if THD_USING_TRO_CONNECTOR build switch enabled, actual future code where both sensors exist on their own connectors if build switch is disabled).

12:58 pm

Quang Nguyen <qnguyen@diality.com>

More
acf0804
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 212 more DG-DEN-8103-1

DEN-8103: Added alarm table size check

- -0
- +3
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -2
- +6
/firmware/checkAlarms.sh
- History
- Source
- Diff
/firmware/checkAlarms.sh

12:42 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

12:40 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I think we should at least say that the mode variables are reset to re-start the mode or something.

I think we should at least say that the mode variables are reset to re-start the mode or something.

12:37 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Why are some values aligned at left and others at right? I think all values should align at left.

Why are some values aligned at left and others at right? I think all values should align at left.

12:32 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

12:28 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Not necessary - included in .h file.

Not necessary - included in .h file.

12:26 pm

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Please keep this case in last position in switch statement.

Please keep this case in last position in switch statement.

11:50 am

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Why commented out?

Why commented out?

10:41 am

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

Remove comments or add TODO.

Remove comments or add TODO.

10:41 am

Sean Nash

More
Re: DG-DEN-8030-1
commented on review

I think we can remove this test code now.

I think we can remove this test code now.

Thursday 03 Jun 2021

10:36 am

Sean Nash

More
Re: DG-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

More
Re: DG-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

More
Re: DG-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

More
Re: DG-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

More
Re: DG-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 02 Jun 2021

4:26 pm

Dara Navaei

More
4354139
changed 1 file
develop_1-24

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

4:26 pm

Dara Navaei

More
50fa189
changed 1 file
develop_1-24

Disabled CAL_CHECK build switch

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

Tuesday 01 Jun 2021

9:52 am

Sean Nash

More
7e522d0
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8030-1

DEN-8030: Updated heater PWM limits for V3.

- -0
- +6
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-10 07:15 -0800