dgfirmware

Clone Tools

Stats

Commits this week: 1
Total Committers: 17
Last Commit: 07 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 Jun 2021
9:29 am

Dara Navaei

DEN-8030 addressed code review comments and added concentrate pumps to heat disinfect

Options
    • -38
    • +0
    /firmware/.launches/DG.launch
    • -48
    • +13
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +0
    /firmware/App/Controllers/DrainPump.h
    • -2
    • +1
    /firmware/App/Controllers/Heaters.c
    • -5
    • +5
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +14
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -33
    • +19
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -131
    • +101
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -8
    • +0
    /firmware/App/Modes/ModeRecirculate.c
9:29 am

qnguyen  (deleted user)

do we need to resolve this conflict?

do we need to resolve this conflict?

Tuesday 15 Jun 2021
5:02 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'staging' into localtest

Options
    • -4
    • +109
    /firmware/App/Controllers/DrainPump.c
    • -12
    • +62
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -3
    • +71
    /firmware/App/Controllers/ROPump.c
    • -1
    • +2
    /firmware/App/Controllers/ROPump.h
    • -3
    • +3
    /firmware/App/DGCommon.h
    • -2
    • +56
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +9
    /firmware/App/Modes/ModeFault.c
    • -6
    • +6
    /firmware/App/Modes/ModeFlush.c
    • -3
    • +158
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -17
    • +47
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +3
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +18
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +3
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -27
    • +57
    /firmware/App/Services/FPGA.c
  16. … 4 more files in changeset.
3:04 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added range check for pressure sensor

Options
    • -7
    • +16
    /firmware/App/Controllers/Pressures.c
1:29 pm

Dara Navaei

Done.

Done.

11:12 am

Dara Navaei

Done.

Done.

11:05 am

Dara Navaei

Done.

Done.

11:04 am

Dara Navaei

Done.

Done.

10:34 am

Dara Navaei

10:19 am

Dara Navaei

Done.

Done.

10:15 am

Sean Nash

Please remove dead code.

Please remove dead code.

10:14 am

Sean Nash

Should this be F64 as well?

Should this be F64 as well?

10:11 am

Sean Nash

Remove dead code.

Remove dead code.

10:10 am

Sean Nash

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

10:03 am

Sean Nash

Not quite what I had in mind. I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature. Inside TempSensors, you would have the build switch...

Not quite what I had in mind.
I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature.
Inside TempSensors, you would have the build switch. If using TRO connector for new sensor, fill THd from TRo temp sensor and fill TRo from TDi temp sensor (both TDi and TRo share TDi sensor). If THd has its own connector (DVT system?), then fill THd from THd sensor and TRo from TRo sensor as you would normally expect.

Sunday 13 Jun 2021
5:35 pm

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -4
    • +17
    /firmware/App/Modes/ModeChemicalDisinfect.c
5:27 pm

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -2
    • +7
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.h
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -6
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -4
    • +24
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeRecirculate.c
    • -28
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +2
    /firmware/App/Services/Reservoirs.c
    • -0
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.c
5:22 pm

Dara Navaei

Done

Done

4:19 pm

Dara Navaei

Done.

Done.

4:19 pm

Dara Navaei

Done.

Done.

4:19 pm

Dara Navaei

This was for testing. It is uncommented.

This was for testing. It is uncommented.

4:18 pm

Dara Navaei

Done.

Done.

4:17 pm

Dara Navaei

I removed it.

I removed it.

4:10 pm

Dara Navaei

Done

Done

4:08 pm

Dara Navaei

I removed the function.

I removed the function.

4:01 pm

Dara Navaei

Done.

Done.

4:00 pm

Dara Navaei

Done.

Done.

3:59 pm

Dara Navaei

DEN-8030 merged staging

Options
    • -0
    • +27
    /firmware/.launches/DG.launch
    • -4
    • +109
    /firmware/App/Controllers/DrainPump.c
    • -0
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -10
    • +5
    /firmware/App/Controllers/TemperatureSensors.c
    • -15
    • +76
    /firmware/App/Controllers/Valves.c
    • -0
    • +1
    /firmware/App/Controllers/Valves.h
    • -3
    • +4
    /firmware/App/DGCommon.h
    • -19
    • +69
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +7
    /firmware/App/Modes/ModeFault.c
    • -2
    • +143
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -13
    • +44
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +2
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +14
    /firmware/App/Modes/OperationModes.c
  16. … 7 more files in changeset.
2:52 pm

Dara Navaei

DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

Options
    • -183
    • +15
    /firmware/App/Controllers/Heaters.c
    • -2
    • +0
    /firmware/App/Controllers/Heaters.h
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -0
    • +5
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +4
    /firmware/App/Modes/ModeFill.c
    • -69
    • +130
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -6
    • +0
    /firmware/App/Modes/ModeInitPOST.c
    • -3
    • +7
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
Thursday 10 Jun 2021
3:21 pm

Sean Nash