dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 Jun 2021
3:00 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Added init for integrity module

Options
    • -0
    • +1
    /firmware/source/sys_main.c
10:43 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

qnguyen  (deleted user)

Target speed has to set to get direction going before turning the pumps on.

Target speed has to set to get direction going before turning the pumps on.

10:26 am

qnguyen  (deleted user)

Do we need this include?

Do we need this include?

10:17 am

qnguyen  (deleted user)

Why is this check removed?

Why is this check removed?

10:13 am

qnguyen  (deleted user)

Should this value be higher? The user could be using wrong concentrate jug if it is too low?

Should this value be higher? The user could be using wrong concentrate jug if it is too low?

10:10 am

qnguyen  (deleted user)

This should be a separate if. Otherwise, this else if is not reachable.

This should be a separate if. Otherwise, this else if is not reachable.

10:07 am

qnguyen  (deleted user)

Remove TODO once the original has been brought back.

Remove TODO once the original has been brought back.

10:04 am

qnguyen  (deleted user)

Instead of retry logic, should we just double the time out? This retry is essentially extended the time one more without any action to correct the first time out.

Instead of retry logic, should we just double the time out? This retry is essentially extended the time one more without any action to correct the first time out.

9:46 am

qnguyen  (deleted user)

Should this flag be deleted since we no longer have any V2 DG?

Should this flag be deleted since we no longer have any V2 DG?

9:32 am

Dara Navaei

Done.

Done.

9:29 am

Dara Navaei

DEN-8030 addressed code review comments and added concentrate pumps to heat disinfect

Options
    • -38
    • +0
    /firmware/.launches/DG.launch
    • -48
    • +13
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +0
    /firmware/App/Controllers/DrainPump.h
    • -2
    • +1
    /firmware/App/Controllers/Heaters.c
    • -5
    • +5
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +14
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -33
    • +19
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -131
    • +101
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -8
    • +0
    /firmware/App/Modes/ModeRecirculate.c
9:29 am

qnguyen  (deleted user)

do we need to resolve this conflict?

do we need to resolve this conflict?

Tuesday 15 Jun 2021
5:02 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'staging' into localtest

Options
    • -4
    • +109
    /firmware/App/Controllers/DrainPump.c
    • -12
    • +62
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -3
    • +71
    /firmware/App/Controllers/ROPump.c
    • -1
    • +2
    /firmware/App/Controllers/ROPump.h
    • -3
    • +3
    /firmware/App/DGCommon.h
    • -2
    • +56
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +9
    /firmware/App/Modes/ModeFault.c
    • -6
    • +6
    /firmware/App/Modes/ModeFlush.c
    • -3
    • +158
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -17
    • +47
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +3
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +18
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +3
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -27
    • +57
    /firmware/App/Services/FPGA.c
  16. … 4 more files in changeset.
3:04 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added range check for pressure sensor

Options
    • -7
    • +16
    /firmware/App/Controllers/Pressures.c
1:29 pm

Dara Navaei

Done.

Done.

11:12 am

Dara Navaei

Done.

Done.