dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Jul 2021
9:54 am

Dara Navaei

DEN-9054 addressed code review comments

Options
    • -14
    • +9
    /firmware/App/Controllers/Switches.c
    • -4
    • +48
    /firmware/App/Services/FPGA.c
    • -1
    • +5
    /firmware/App/Services/FPGA.h
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
9:07 am

Dara Navaei

Done.

Done.

Wednesday 28 Jul 2021
8:58 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -11
    • +0
    /firmware/App/Controllers/Pressures.c
    • -52
    • +58
    /firmware/App/Controllers/Switches.c
    • -0
    • +17
    /firmware/dg_build_history.log
    • -10
    • +0
    /firmware/dg_build_history.txt
8:54 pm

Dara Navaei

This is fixed in the latest commit.

This is fixed in the latest commit.

8:46 pm

Dara Navaei

Done.

Done.

8:45 pm

Dara Navaei

The default pump control mode is none.

The default pump control mode is none.

8:44 pm

Dara Navaei

Done.

Done.

8:09 pm

Dara Navaei

Done.

Done.

8:07 pm

Dara Navaei

Done.

Done.

8:06 pm

Dara Navaei

Done.

Done.

8:04 pm

Dara Navaei

8:04 pm

Dara Navaei

This structure was transferred DGDefs.h

This structure was transferred DGDefs.h

3:59 pm

Sean Nash

DEN-8886: Updated WD POST test.

Options
    • -13
    • +28
    /firmware/App/Services/WatchdogMgmt.c
3:10 pm

Sean Nash

DEN-8886: Added handling for DG POST result request message.

Options
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +34
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Tuesday 27 Jul 2021
5:50 pm

Sean Nash

Where did this go?

Where did this go?

5:15 pm

Sean Nash

So these & operators are going to yield a zero or a non-zero number that will be different for each switch (not a boolean). I think your intent is for these switch data to be an enum. So, for examp...

So these & operators are going to yield a zero or a non-zero number that will be different for each switch (not a boolean). I think your intent is for these switch data to be an enum. So, for example, this one should be "... = ( ( fpgaRegister & CONCENTRATE_CAP_SWITCH_BIT_MASK ) != 0 ? OPEN : CLOSED );

5:13 pm

Sean Nash

Put test functions at bottom of module (after usual banner).

Put test functions at bottom of module (after usual banner).

5:04 pm

Sean Nash

I don't see this being initialized in init function.

I don't see this being initialized in init function.

4:16 pm

Sean Nash

I like to add a comment to right of system library includes explaining why they are needed (i.e. which math functions are you using in this module).

I like to add a comment to right of system library includes explaining why they are needed (i.e. which math functions are you using in this module).

Monday 26 Jul 2021
10:31 am

Sean Nash

Should we close both drain valves VRd1 and VRd2 here?

Should we close both drain valves VRd1 and VRd2 here?

10:24 am

Sean Nash

I think other fill volumes would come from HD, so we can remove this TODO.

I think other fill volumes would come from HD, so we can remove this TODO.

10:21 am

Sean Nash

The GPIO register is shared (e.g. see fluid leak in above function). So I think we should have separate functions for each bit that we use in the GPIO register. Also - why does the function name ha...

The GPIO register is shared (e.g. see fluid leak in above function). So I think we should have separate functions for each bit that we use in the GPIO register.
Also - why does the function name have the word Count in it?

10:17 am

Sean Nash

Please restore the vector length test.

Please restore the vector length test.

10:12 am

Sean Nash

How is this used?

How is this used?

10:10 am

Sean Nash

I think these @param descriptions could fit in one line for a cleaner look.

I think these @param descriptions could fit in one line for a cleaner look.

10:07 am

Sean Nash

For consistency, can we put Dialin functions at end?

For consistency, can we put Dialin functions at end?

10:00 am

Sean Nash

Compatibility check should be before FPGA test at end where it was. We can't do it this early because UI may not have provided us with version/compatibility info yet.

Compatibility check should be before FPGA test at end where it was. We can't do it this early because UI may not have provided us with version/compatibility info yet.

9:06 am

Dara Navaei

DEN-9054 updated the build history file

Options
    • -4
    • +4
    /firmware/dg_build_history.txt
Sunday 25 Jul 2021
4:16 pm

Dara Navaei

DEN-9054 added switches to the sys_main

Options
    • -0
    • +1
    /firmware/App/Controllers/Switches.c
    • -1
    • +1
    /firmware/App/Controllers/Switches.h
    • -1
    • +1
    /firmware/dg_build_history.txt
    • -0
    • +2
    /firmware/source/sys_main.c
Saturday 24 Jul 2021
4:28 pm

Dara Navaei

DEN-9054 initial commit of the switches driver

Options
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -0
    • +248
    /firmware/App/Controllers/Switches.c
    • -0
    • +55
    /firmware/App/Controllers/Switches.h
    • -3
    • +4
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +12
    /firmware/App/Services/FPGA.c
    • -1
    • +3
    /firmware/App/Services/FPGA.h
    • -0
    • +8
    /firmware/App/Services/SystemComm.c
    • -0
    • +92
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +10
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +5
    /firmware/App/Tasks/TaskGeneral.c