dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7802: Added checks for alarm priority table

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Need to have 2 blank lines.

Need to have 2 blank lines.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Need to add a check if switchId is in valid range.

Need to add a check if switchId is in valid range.

Do we need to add copyrights or bamboo will do it?

Do we need to add copyrights or bamboo will do it?

Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.

Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

What happens when calibration data is invalid?

What happens when calibration data is invalid?

The comment is out-date and need to be updated.

The comment is out-date and need to be updated.

Param name is not matched.

Param name is not matched.

This can fit in one line.

This can fit in one line.

Should it be 0 and is the first one in the enumeration?

Should it be 0 and is the first one in the enumeration?

DEN-9054 addressed code review comments

    • -14
    • +9
    /firmware/App/Controllers/Switches.c
Done.

Done.

DEN-9054 addressed the code review comments

    • -11
    • +0
    /firmware/App/Controllers/Pressures.c
    • -52
    • +58
    /firmware/App/Controllers/Switches.c
    • -0
    • +17
    /firmware/dg_build_history.log
This is fixed in the latest commit.

This is fixed in the latest commit.

Done.

Done.

The default pump control mode is none.

The default pump control mode is none.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.