dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Nov 2021
4:56 pm

Dara Navaei

Removed the RTC RAM write in Fill mode. Quick fix

Options
    • -1
    • +0
    /firmware/App/Modes/ModeFill.c
11:39 am

Sean Nash

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

11:17 am

Sean Nash

Who would call this function?

Who would call this function?

11:15 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
11:14 am

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
11:14 am

Dara Navaei

Removed a DEBUG_DENALI comment

Options
    • -2
    • +0
    /firmware/App/Controllers/TemperatureSensors.c
11:13 am

Sean Nash

We're saving fill data to RTC RAM every 50ms?

We're saving fill data to RTC RAM every 50ms?

11:11 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
11:10 am

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
11:10 am

Dara Navaei

Merged DEN-9480 and resolved merge conflicts

Options
    • -37
    • +114
    /firmware/App/Controllers/DrainPump.c
    • -74
    • +130
    /firmware/App/Controllers/Heaters.c
    • -2
    • +1
    /firmware/App/Controllers/ROPump.c
    • -0
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -31
    • +58
    /firmware/App/Modes/ModeDrain.c
    • -28
    • +62
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
    • -2
    • +0
    /firmware/App/Modes/ModeGenIdle.c
    • -3
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +6
    /firmware/App/Services/SystemComm.c
    • -3
    • +35
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +5
    /firmware/App/Services/SystemCommMessages.h
11:09 am

Sean Nash

What's happening here? Why subtract 0?

What's happening here? Why subtract 0?

10:52 am

Dara Navaei

DEN-9480 tested RTC stop clock and drain mode

Options
    • -0
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeService.h
9:20 am

Sean Nash

I don't see where this alarm is being triggered.

I don't see where this alarm is being triggered.

Thursday 04 Nov 2021
11:45 am

Sean Nash

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

11:44 am

Sean Nash

Should we keep the TODO for this?

Should we keep the TODO for this?

11:40 am

Sean Nash

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

11:38 am

Hung Nguyen <hnguyen@diality.com>

DEN-9906 Added new alarm ID for dialysate flow out of range

Options
    • -2
    • +1
    /firmware/App/Controllers/DialysateFlow.c
11:26 am

Sean Nash

Make a private definitions section above private data and move this there.

Make a private definitions section above private data and move this there.

11:25 am

Sean Nash

Should this module be removed (replaced by ModeGenIdle)?

Should this module be removed (replaced by ModeGenIdle)?

10:47 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:38 am

hnguyen  (deleted user)

Added new alarm ID for dialysate flow out of range.

Added new alarm ID for dialysate flow out of range.

10:37 am

Hung Nguyen <hnguyen@diality.com>

DEN-9906 Added new alarm ID for dialysate flow out of range

Options
    • -2
    • +1
    /firmware/App/Controllers/DialysateFlow.c
10:34 am

Sean Nash

Handling of passive notification is removed in my branch.

Handling of passive notification is removed in my branch.

10:33 am

Sean Nash

Debug code is removed in my branch. Should s/w fault here I think.

Debug code is removed in my branch. Should s/w fault here I think.

10:33 am

Sean Nash

This is removed in my branch.

This is removed in my branch.

10:03 am

Sean Nash

Make a build switch to disable ACK alarms.

Make a build switch to disable ACK alarms.

10:00 am

Sean Nash

Can the two datas be memcpy'd as EVENT_DATA_Ts instead of U32 and EVENT_DATAS_T separately?

Can the two datas be memcpy'd as EVENT_DATA_Ts instead of U32 and EVENT_DATAS_T separately?

9:58 am

Sean Nash

Let's finish optimizing broadcasts.

Let's finish optimizing broadcasts.

9:48 am

Sean Nash

There are now 2 DG flow sensors (FMP and FMD).

There are now 2 DG flow sensors (FMP and FMD).

Wednesday 03 Nov 2021
9:26 pm

Dara Navaei

DEN-9480, DEN-10788 continued working on the heaters control and added code to be able override the drain pump RPM once the pump is in the open loop mode

Options
    • -36
    • +99
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +8
    /firmware/App/Controllers/DrainPump.h
    • -49
    • +106
    /firmware/App/Controllers/Heaters.c
    • -0
    • +4
    /firmware/App/Controllers/Heaters.h
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -4
    • +6
    /firmware/App/Drivers/SafetyShutdown.c
    • -1
    • +8
    /firmware/App/Drivers/SafetyShutdown.h
    • -4
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -27
    • +56
    /firmware/App/Modes/ModeDrain.c
    • -4
    • +24
    /firmware/App/Modes/ModeFill.c
    • -1
    • +0
    /firmware/App/Modes/ModeFill.h
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
    • -3
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -10
    • +14
    /firmware/App/Modes/ModeStandby.c
  16. … 3 more files in changeset.