dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 Jan 2022
1:48 pm

Dara Navaei

Merged DEN-11114 and resolved merge conflicts

Options
    • -64
    • +15
    /firmware/App/Controllers/ConcentratePumps.c
    • -45
    • +4
    /firmware/App/Controllers/LoadCell.c
    • -47
    • +5
    /firmware/App/Controllers/ROPump.c
    • -2
    • +3
    /firmware/App/Modes/ModeDrain.c
    • -12
    • +62
    /firmware/App/Modes/ModeFill.c
    • -5
    • +16
    /firmware/App/Services/SystemCommMessages.c
1:41 pm

Dara Navaei

DEN-11698 added a check to cap the concentrate pumps speed in the fill mode

Options
    • -2
    • +6
    /firmware/App/Modes/ModeFill.c
11:11 am

hnguyen  (deleted user)

Remove blank line here.

Remove blank line here.

10:52 am

hnguyen  (deleted user)

Insert a space between the last '0' and '}' in OVERRIDE_32_T type.

Insert a space between the last '0' and '}' in OVERRIDE_32_T type.

9:25 am

Sean Nash

Is this build switch still used?

Is this build switch still used?

9:23 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

9:17 am

Sean Nash

Add alarm.

Add alarm.

9:17 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:16 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

9:16 am

Sean Nash

I prefer to declare variables at top of scope (after '{' above).

I prefer to declare variables at top of scope (after '{' above).

9:15 am

Sean Nash

Remove extra space after F32.

Remove extra space after F32.

9:12 am

Sean Nash

Should these come from calibration record or ok to hard code?

Should these come from calibration record or ok to hard code?

9:10 am

Sean Nash

This comment seems redundant.

This comment seems redundant.

9:09 am

Sean Nash

Add doxygen comments.

Add doxygen comments.

9:08 am

Sean Nash

Comment doesn't match code (1 vs 2 degrees). What is the TODO here? Is this temporary code?

Comment doesn't match code (1 vs 2 degrees).
What is the TODO here? Is this temporary code?

9:07 am

Sean Nash

Let's decide this now and remove TODO.

Let's decide this now and remove TODO.

9:06 am

Sean Nash

If no test support functions, remove this banner.

If no test support functions, remove this banner.

8:58 am

Sean Nash

Can we remove these now? Update message list and UI unhandled message conf file.

Can we remove these now? Update message list and UI unhandled message conf file.

8:55 am

Sean Nash

Blank line between declaration and code. Fix indentation. Fix magic number 1000.0.

Blank line between declaration and code.
Fix indentation.
Fix magic number 1000.0.

8:52 am

Sean Nash

Why is this code commented out?

Why is this code commented out?

8:52 am

Sean Nash

Why is this code commented out?

Why is this code commented out?

8:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:51 am

Sean Nash

Yes, I think we do need to check efficiency.

Yes, I think we do need to check efficiency.

8:50 am

Sean Nash

I think we have macros in common.h to do this kind of thing.

I think we have macros in common.h to do this kind of thing.

8:49 am

Sean Nash

I think we need to restore this code.

I think we need to restore this code.

8:48 am

Sean Nash

Can we remove this now?

Can we remove this now?

8:47 am

Sean Nash

???

???

8:42 am

Sean Nash

Should use OVERRIDE_RESET (which is 0) here.

Should use OVERRIDE_RESET (which is 0) here.

8:38 am

Sean Nash

I'm not understanding why + 1 is needed for these.

I'm not understanding why + 1 is needed for these.

8:36 am

Sean Nash

Let's just solve this now instead of commenting it out.

Let's just solve this now instead of commenting it out.