dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged DEN-11114 and resolved merge conflicts

    • -45
    • +4
    /firmware/App/Controllers/LoadCell.c
DEN-11698 added a check to cap the concentrate pumps speed in the fill mode

Remove blank line here.

Remove blank line here.

Insert a space between the last '0' and '}' in OVERRIDE_32_T type.

Insert a space between the last '0' and '}' in OVERRIDE_32_T type.

Is this build switch still used?

Is this build switch still used?

Add blank line between declarations and code.

Add blank line between declarations and code.

Add alarm.

Add alarm.

Remove extra blank line.

Remove extra blank line.

Add blank line between declarations and code.

Add blank line between declarations and code.

I prefer to declare variables at top of scope (after '{' above).

I prefer to declare variables at top of scope (after '{' above).

Remove extra space after F32.

Remove extra space after F32.

Should these come from calibration record or ok to hard code?

Should these come from calibration record or ok to hard code?

This comment seems redundant.

This comment seems redundant.

Add doxygen comments.

Add doxygen comments.

Comment doesn't match code (1 vs 2 degrees). What is the TODO here? Is this temporary code?

Comment doesn't match code (1 vs 2 degrees).
What is the TODO here? Is this temporary code?

Let's decide this now and remove TODO.

Let's decide this now and remove TODO.

If no test support functions, remove this banner.

If no test support functions, remove this banner.

Can we remove these now? Update message list and UI unhandled message conf file.

Can we remove these now? Update message list and UI unhandled message conf file.

Blank line between declaration and code. Fix indentation. Fix magic number 1000.0.

Blank line between declaration and code.
Fix indentation.
Fix magic number 1000.0.

Why is this code commented out?

Why is this code commented out?

Why is this code commented out?

Why is this code commented out?

Remove extra blank line.

Remove extra blank line.

Yes, I think we do need to check efficiency.

Yes, I think we do need to check efficiency.

I think we have macros in common.h to do this kind of thing.

I think we have macros in common.h to do this kind of thing.

I think we need to restore this code.

I think we need to restore this code.

Can we remove this now?

Can we remove this now?

???

???

Should use OVERRIDE_RESET (which is 0) here.

Should use OVERRIDE_RESET (which is 0) here.

I'm not understanding why + 1 is needed for these.

I'm not understanding why + 1 is needed for these.

Let's just solve this now instead of commenting it out.

Let's just solve this now instead of commenting it out.