dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Mar 2022
5:39 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated per peer review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -15
    • +17
    /firmware/App/Modes/ModeDrain.c
    • -50
    • +10
    /firmware/App/Modes/ModeFill.c
    • -5
    • +1
    /firmware/App/Modes/ModeFill.h
    • -16
    • +25
    /firmware/App/Modes/ModeGenIdle.c
4:55 pm

hnguyen  (deleted user)

Idle mode calls BOOL isAvgConductivityOutOfRange( void ){ return fillStatus.fillAvgConductivityOutOfRange; }

Idle mode calls
BOOL isAvgConductivityOutOfRange( void )

Unknown macro: { return fillStatus.fillAvgConductivityOutOfRange; }
4:04 pm

hnguyen  (deleted user)

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

4:02 pm

hnguyen  (deleted user)

This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c

This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c

3:43 pm

hnguyen  (deleted user)

Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );

Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );

2:17 pm

hnguyen  (deleted user)

Set result = DG_HANDLE_BAD_FILL_STATE_START;

Set result = DG_HANDLE_BAD_FILL_STATE_START;

2:01 pm

hnguyen  (deleted user)

Wait here for alarm is no longer active, then transition to fill mode.

Wait here for alarm is no longer active, then transition to fill mode.

1:31 pm

hnguyen  (deleted user)

Done.

Done.

1:30 pm

hnguyen  (deleted user)

Done.

Done.

1:03 pm

hnguyen  (deleted user)

Removed flushWaterVolumeL.

Removed flushWaterVolumeL.

1:02 pm

hnguyen  (deleted user)

Removed TARGET_FLUSH_WATER_RO_FLOW_RATE_L

Removed TARGET_FLUSH_WATER_RO_FLOW_RATE_L

12:59 pm

hnguyen  (deleted user)

Replaced with activateAlarmNoData.

Replaced with activateAlarmNoData.

12:55 pm

hnguyen  (deleted user)

Changed this function to private.

Changed this function to private.

12:50 pm

hnguyen  (deleted user)

Removed requestNewOperationMode( DG_MODE_GENE );

Removed requestNewOperationMode( DG_MODE_GENE );

12:49 pm

hnguyen  (deleted user)

Removed requestNewOperationMode( DG_MODE_GENE );

Removed requestNewOperationMode( DG_MODE_GENE );

11:23 am

hnguyen  (deleted user)

Removed return.

Removed return.

11:08 am

hnguyen  (deleted user)

Changed COND_SENSOR_CPI_WARNING_HIGH to COND_SENSOR_CPI_WARNING_LOW

Changed COND_SENSOR_CPI_WARNING_HIGH to COND_SENSOR_CPI_WARNING_LOW

10:58 am

hnguyen  (deleted user)

Done.

Done.

10:53 am

hnguyen  (deleted user)

Done.

Done.

10:42 am

hnguyen  (deleted user)

Updated NoRin, NoEnd, ClrOnly to FALSE.

Updated NoRin, NoEnd, ClrOnly to FALSE.

10:24 am

Sean Nash

Would also set internal signal flag to FALSE here so next call to idle exec will get us back into the normal flush water state.

Would also set internal signal flag to FALSE here so next call to idle exec will get us back into the normal flush water state.

10:18 am

Sean Nash

I don't think we should be using bad fill to make this decision. It will work first time but bad fill workflow will do 2 more fills that hopefully will not be bad fills and yet we still want to sta...

I don't think we should be using bad fill to make this decision. It will work first time but bad fill workflow will do 2 more fills that hopefully will not be bad fills and yet we still want to stay in the bad fill state until we finish the bad fill workflow.
So what I think we should be doing is having fill mode signal idle mode (call a signal function from fill mode when bad avg conductivity detected which sets a flag here in idle mode).

10:14 am

Sean Nash

Need to make sure this fill will target the normal fill volume (not 1,000 mL this time).

Need to make sure this fill will target the normal fill volume (not 1,000 mL this time).

10:13 am

Sean Nash

We need to wait in this state (don't fill yet) if the first alarm has not yet been cleared by user (indicating user has confirmed replacement of bottles). So need an "if" here. Also, we need to do ...

We need to wait in this state (don't fill yet) if the first alarm has not yet been cleared by user (indicating user has confirmed replacement of bottles).
So need an "if" here.
Also, we need to do something so that the next fill will only go to 1,000 mL.

10:10 am

Sean Nash

Should set back to start state for next time.

Should set back to start state for next time.

10:09 am

Sean Nash

Should just set result to this state above at declaration to simplify.

Should just set result to this state above at declaration to simplify.

10:09 am

Sean Nash

Should just set result to this state above at declaration to simplify.

Should just set result to this state above at declaration to simplify.

10:09 am

Sean Nash

Should just set result to this state above at declaration to simplify.

Should just set result to this state above at declaration to simplify.

9:59 am

Sean Nash

We can't initialize bad fill state here because this init function gets called every time we come back to idle mode. I think we should initialize the badFillState in the start state when we decide ...

We can't initialize bad fill state here because this init function gets called every time we come back to idle mode.
I think we should initialize the badFillState in the start state when we decide to go to the flush water (normal) state.

9:45 am

Sean Nash

Don't need this volume variable. You are only initializing it and then never using it.

Don't need this volume variable. You are only initializing it and then never using it.