dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Mar 2022
2:32 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Update per review

Options
    • -3
    • +1
    /firmware/App/Modes/ModeDrain.c
2:30 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Update per review

Options
    • -2
    • +3
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +0
    /firmware/App/Modes/ModeFill.c
2:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:16 pm

hnguyen  (deleted user)

Sean is OK with current implementation.

Sean is OK with current implementation.

2:14 pm

hnguyen  (deleted user)

Sean is OK with current implementation.

Sean is OK with current implementation.

1:56 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated per peer review comments

Options
    • -20
    • +16
    /firmware/App/Modes/ModeDrain.c
    • -26
    • +5
    /firmware/App/Modes/ModeFill.c
    • -2
    • +0
    /firmware/App/Modes/ModeFill.h
    • -14
    • +27
    /firmware/App/Modes/ModeGenIdle.c
    • -0
    • +1
    /firmware/App/Modes/ModeGenIdle.h
1:42 pm

hnguyen  (deleted user)

Added signal function setBadAvgConductivityDetectedFlag( BOOL flag ) in ModeGenIdle.

Added signal function setBadAvgConductivityDetectedFlag( BOOL flag ) in ModeGenIdle.

11:22 am

hnguyen  (deleted user)

Initialized badFillState where it is declared in the private data section.

Initialized badFillState where it is declared in the private data section.

10:53 am

hnguyen  (deleted user)

Added genIdleState = DG_GEN_IDLE_MODE_STATE_START;

Added
genIdleState = DG_GEN_IDLE_MODE_STATE_START;

Tuesday 22 Mar 2022
6:18 pm

hnguyen  (deleted user)

Removed line //requestNewOperationMode( DG_MODE_GENE );

Removed line

//requestNewOperationMode( DG_MODE_GENE );

6:18 pm

hnguyen  (deleted user)

Removed line //activateAlarmNoData( ALARM_ID_DG_ACID_BOTTLE_LOW_VOLUME );

Removed line

//activateAlarmNoData( ALARM_ID_DG_ACID_BOTTLE_LOW_VOLUME );

6:16 pm

hnguyen  (deleted user)

Moved check for empty bottles before if ( TRUE == isReservoirTarePending() )

Moved check for empty bottles before if ( TRUE == isReservoirTarePending() )

6:14 pm

hnguyen  (deleted user)

Removed else requestNewOperationMode( DG_MODE_GENE );

Removed else requestNewOperationMode( DG_MODE_GENE );

6:13 pm

hnguyen  (deleted user)

Uncommented requestNewOperationMode( )

Uncommented requestNewOperationMode( )

6:01 pm

hnguyen  (deleted user)

Added doxygen comment DG_HANDLE_BAD_FILL_STATE_START = 0, ///< Bad fill start state

Added doxygen comment

DG_HANDLE_BAD_FILL_STATE_START = 0, ///< Bad fill start state

6:00 pm

hnguyen  (deleted user)

Added doxygen comment ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 106, ///< DG inlet water conductivity is greater than threshold

Added doxygen comment

ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 106, ///< DG inlet water conductivity is greater than threshold

5:55 pm

hnguyen  (deleted user)

Removed U32 fillToVolumeML = 1000; Added #define BAD_FLUSH_FILL_TARGET_VOLUME_ML 1000

Removed U32 fillToVolumeML = 1000;
Added #define BAD_FLUSH_FILL_TARGET_VOLUME_ML 1000

5:48 pm

hnguyen  (deleted user)

Removed 2 unused thresholds: #define CONDUCTIVITY_WHEN_ACID_JUG_EMPTY 10000.0 #define CONDUCTIVITY_WHEN_BICARB_JUG_EMPTY 12000.0

Removed 2 unused thresholds:

#define CONDUCTIVITY_WHEN_ACID_JUG_EMPTY 10000.0
#define CONDUCTIVITY_WHEN_BICARB_JUG_EMPTY 12000.0

5:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:36 pm

Sean Nash

Maybe remove thresholds for now as we are not using them yet.

Maybe remove thresholds for now as we are not using them yet.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.