Activity dgfirmware/

2:55 pm

Hung Nguyen <hnguyen@diality.com>

More
be3f2d4
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Update per review

- -10
- +3
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c

2:52 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:49 pm

Dara Navaei

More
7498376
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

2:49 pm

Hung Nguyen <hnguyen@diality.com>

More
d224627
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updater per review

- -0
- +1
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c

2:47 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:46 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to Sean Nash

Reviewed requirement - it is obsolete.

2:45 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to Sean Nash

Reviewed requirement - it is obsolete.

2:43 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:42 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:39 pm

Dara Navaei

More
9ef33a8
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

2:39 pm

Dara Navaei

More
395ea41
changed 2 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-1224 added a build switch

- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

2:37 pm

Dara Navaei

More
73f039b
changed 3 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged DEN-12224

- -18
- +38
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -14
- +23
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

2:37 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:33 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:33 pm

Dara Navaei

More
3414e47
changed 6 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 worked on the concentrate pumps

- -18
- +38
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -0
- +2
/firmware/App/Controllers/ConcentratePumps.h
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.h
- -14
- +23
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -0
- +4
/firmware/App/Controllers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -4
- +4
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c

2:32 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:32 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

Retract issue - looking at latest code it is needed. Else and mode change request restored. RESOLVED in CODE WALKTHROUGH.

2:32 pm

Hung Nguyen <hnguyen@diality.com>

More
549b759
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Update per review

- -3
- +1
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c

2:30 pm

Hung Nguyen <hnguyen@diality.com>

More
595c1ce
changed 2 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Update per review

- -2
- +3
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -1
- +0
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

2:24 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:16 pm

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Sean is OK with current implementation.

2:14 pm

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Sean is OK with current implementation.

1:56 pm

Hung Nguyen <hnguyen@diality.com>

More
773bd9e
changed 5 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updated per peer review comments

- -20
- +16
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -26
- +5
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -2
- +0
/firmware/App/Modes/ModeFill.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.h
- -14
- +27
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -0
- +1
/firmware/App/Modes/ModeGenIdle.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.h

1:42 pm

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

Added signal function setBadAvgConductivityDetectedFlag( BOOL flag ) in ModeGenIdle.

11:22 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Initialized badFillState where it is declared in the private data section.

dgfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Sean Nash

Sean Nash

Hung Nguyen <hnguyen@diality.com>

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

Hung Nguyen <hnguyen@diality.com>

hnguyen (deleted user)

hnguyen (deleted user)