dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 31 Mar 2022
11:09 am

Dara Navaei

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

Options
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
9:09 am

Dara Navaei

DEN-11928 addressed the code review comments

Options
    • -3
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +27
    /firmware/App/Modes/ModeFill.c
    • -23
    • +28
    /firmware/App/Modes/ModeGenIdle.c
    • -0
    • +3
    /firmware/App/Modes/ModeGenIdle.h
Wednesday 30 Mar 2022
9:38 pm

Dara Navaei

Done.

Done.

9:33 pm

Dara Navaei

It is initialized in the init function and it is staggered.

It is initialized in the init function and it is staggered.

8:55 pm

Dara Navaei

DEN-11928 updated the fill mode and the RO pump

Options
    • -7
    • +7
    /firmware/App/Controllers/ROPump.c
    • -0
    • +1
    /firmware/App/Controllers/ROPump.h
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -8
    • +3
    /firmware/App/Modes/ModeFill.c
7:41 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Corrected logic errors

Options
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
4:31 pm

Dara Navaei

DEN-11928 updated the alarms and fill mode

Options
    • -22
    • +29
    /firmware/App/Controllers/ConductivitySensors.c
    • -21
    • +15
    /firmware/App/Controllers/Pressures.c
    • -1
    • +0
    /firmware/App/Controllers/Pressures.h
    • -9
    • +24
    /firmware/App/Controllers/ROPump.c
    • -0
    • +1
    /firmware/App/Controllers/ROPump.h
    • -24
    • +22
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/DGCommon.h
    • -37
    • +16
    /firmware/App/Modes/ModeFill.c
    • -2
    • +3
    /firmware/App/Modes/ModeFill.h
3:31 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated code per peer review

Options
    • -0
    • +1
    /firmware/App/Modes/ModeGenIdle.c
3:26 pm

hnguyen  (deleted user)

Initialized hdLostCommStartTime_ms in void initGenIdleMode( void )

Initialized hdLostCommStartTime_ms
in void initGenIdleMode( void )

2:18 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated per peer review

Options
    • -2
    • +6
    /firmware/App/Modes/ModeFill.c
    • -1
    • +2
    /firmware/App/Modes/ModeGenIdle.c
2:06 pm

hnguyen  (deleted user)

Changed TxLog field from TRUE to FALSE

Changed TxLog field from TRUE to FALSE

2:00 pm

hnguyen  (deleted user)

Moved publishBadFillSubstates(); to the end of execGenIdle function

Moved publishBadFillSubstates(); to the end of execGenIdle function

1:54 pm

hnguyen  (deleted user)

Added test separator below /************************************************************************* *TEST SUPPORT FUNCTIONS *********************************************************************...

Added test separator below
/*************************************************************************

  • TEST SUPPORT FUNCTIONS
    *************************************************************************/
1:46 pm

hnguyen  (deleted user)

deleted blank line

deleted blank line

1:44 pm

hnguyen  (deleted user)

Aligned this comment with other comments ///< Used to schedule dialysate fill data publication to CAN bus.

Aligned this comment with other comments
///< Used to schedule dialysate fill data publication to CAN bus.

1:36 pm

Sean Nash

Clear alarm condition, not alarm.

Clear alarm condition, not alarm.

1:34 pm

Sean Nash

Do we still need this?

Do we still need this?

1:29 pm

Sean Nash

Remove blank line.

Remove blank line.

1:13 pm

Sean Nash

Doesn't next state need acid zeroed here?

Doesn't next state need acid zeroed here?

1:10 pm

Sean Nash

Stagger?

Stagger?

1:10 pm

Sean Nash

delete one of these blank lines.

delete one of these blank lines.

1:09 pm

Sean Nash

Indent comment properly.

Indent comment properly.

1:08 pm

Sean Nash

Add test functions banner separator here.

Add test functions banner separator here.

1:06 pm

Sean Nash

I would move this to end of function in case state machine changes the state.

I would move this to end of function in case state machine changes the state.

1:06 pm

Sean Nash

I don't see this getting initialized anywhere. Should be initialized in init function. Consider stagger when initializing it.

I don't see this getting initialized anywhere. Should be initialized in init function. Consider stagger when initializing it.

1:03 pm

Sean Nash

Is this alarm really logged to treatment log?

Is this alarm really logged to treatment log?

9:06 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
9:06 am

Dara Navaei

Disabled accel post

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
9:00 am

Dara Navaei

DEN-12224 updated the FMP data type conversion

Options
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
Tuesday 29 Mar 2022
10:42 pm

Dara Navaei

DEN-11928 updated the fill mode

Options
    • -85
    • +38
    /firmware/App/Modes/ModeFill.c