dgfirmware

Clone Tools

Stats

Commits this week: 9
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 22 May 2022
2:03 pm

Dara Navaei

DEN-12224 updated the code

Options
    • -9
    • +11
    /firmware/App/Services/SystemCommMessages.c
12:25 pm

Dara Navaei

DEN-12224 updated the code

Options
    • -20
    • +68
    /firmware/App/Controllers/TemperatureSensors.c
    • -9
    • +9
    /firmware/App/Modes/ModeStandby.c
    • -16
    • +19
    /firmware/App/Services/SystemCommMessages.c
12:25 am

Sean Nash

We have a banner above separating system message helpers from Dialin message helpers. Should only be Dialin message helpers below that banner. I think there are a lot of these in the wrong place.

We have a banner above separating system message helpers from Dialin message helpers. Should only be Dialin message helpers below that banner. I think there are a lot of these in the wrong place.

12:23 am

Sean Nash

Add another blank line here.

Add another blank line here.

12:22 am

Sean Nash

Add another blank line here.

Add another blank line here.

12:21 am

Sean Nash

Remove blank line.

Remove blank line.

12:19 am

Sean Nash

Do we still need this build switch?

Do we still need this build switch?

12:15 am

Sean Nash

It doesn't look like we are following this order - looks like controllers are before modes.

It doesn't look like we are following this order - looks like controllers are before modes.

12:13 am

Sean Nash

Remove blank line.

Remove blank line.

12:12 am

Sean Nash

Is this the best place to do this?

Is this the best place to do this?

12:10 am

Sean Nash

Put declarations at top of scope.

Put declarations at top of scope.

12:08 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

12:08 am

Sean Nash

Swap if order.

Swap if order.

12:07 am

Sean Nash

Can we change "r" to "reservoir"?

Can we change "r" to "reservoir"?

12:06 am

Sean Nash

Put declarations at top of scope.

Put declarations at top of scope.

12:04 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

12:02 am

Sean Nash

Can local declarations be moved to top of function?

Can local declarations be moved to top of function?

Saturday 21 May 2022
11:53 pm

Sean Nash

Should we initialize hdMode here since don't want to initialize in init function?

Should we initialize hdMode here since don't want to initialize in init function?

11:52 pm

Sean Nash

Makes me a little nervous that hdMode is never initialized.

Makes me a little nervous that hdMode is never initialized.

11:46 pm

Sean Nash

Add another blank line.

Add another blank line.

11:46 pm

Sean Nash

Is there a rationale for these blank lines in random places?

Is there a rationale for these blank lines in random places?

11:44 pm

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

11:43 pm

Sean Nash

Should we s/w fault if not a valid bottle?

Should we s/w fault if not a valid bottle?

11:42 pm

Sean Nash

Need an else so volume isn't undefined if not acid or bicarb. Should probably also trigger a s/w fault.

Need an else so volume isn't undefined if not acid or bicarb. Should probably also trigger a s/w fault.

11:40 pm

Sean Nash

Can't we just pass a zero in function param list below? Why need a local variable?

Can't we just pass a zero in function param list below? Why need a local variable?

11:36 pm

Sean Nash

Can we put all local declarations at top of function?

Can we put all local declarations at top of function?

11:28 pm

Sean Nash

Remove blank line.

Remove blank line.

11:28 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:27 pm

Sean Nash

Should be NUM_OF_SWITCHES based on enum name and type. Also, no doors - fix comment.

Should be NUM_OF_SWITCHES based on enum name and type. Also, no doors - fix comment.

11:26 pm

Sean Nash

Does this volume ever get read from NV memory at startup?

Does this volume ever get read from NV memory at startup?