dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 Jul 2022
10:37 am

Sean Nash

Should be s/w fault. Add TODO or trigger s/w fault now.

Should be s/w fault. Add TODO or trigger s/w fault now.

10:36 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:34 am

Sean Nash

This assignment should be done above at declaration. Move calStatus declaration above result.

This assignment should be done above at declaration. Move calStatus declaration above result.

10:31 am

Sean Nash

Keep this blank line.

Keep this blank line.

10:17 am

Sean Nash

Do either of these 2 if statements need an else?

Do either of these 2 if statements need an else?

10:15 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:12 am

Sean Nash

Prefer normal if else for calling functions. I see these throughout.

Prefer normal if else for calling functions. I see these throughout.

9:04 am

Sean Nash

What is the point in having these locals? Why not just use the concentratePumps fields directly?

What is the point in having these locals? Why not just use the concentratePumps fields directly?

9:01 am

Sean Nash

This blank line should stay - style is to have blank lines between declarations and code.

This blank line should stay - style is to have blank lines between declarations and code.

9:00 am

Sean Nash

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Wednesday 13 Jul 2022
8:04 pm

Dara Navaei

8:04 pm

Dara Navaei , Michael Garthwaite and Sean Nash

Thursday 07 Jul 2022
7:05 am

Dara Navaei

DG-DEN-12931_DG HD Dev HD DG Dvt Update
DG-DEN-12931_DG HD Dev HD DG Dvt Update
Wednesday 06 Jul 2022
10:54 am

wbracken  (deleted user)

That would also require a change to the requirements.

That would also require a change to the requirements.

Friday 01 Jul 2022
10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 30 Jun 2022
10:09 am

Dara Navaei

Tuesday 28 Jun 2022
3:44 pm

dcox  (deleted user)

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

3:43 pm

dcox  (deleted user)

10-20 seems like a better number, but my sample size is small so I did not change it.

10-20 seems like a better number, but my sample size is small so I did not change it.

3:42 pm

dcox  (deleted user)

Updated

Updated

3:41 pm

dcox  (deleted user)

Updated

Updated

11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.