dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Aug 2022
5:24 pm

Dara Navaei

DEN-12931 addressed the code review comments

Options
    • -5
    • +20
    /firmware/App/Controllers/ConcentratePumps.c
    • -4
    • +4
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +2
    /firmware/App/Controllers/Heaters.c
    • -13
    • +43
    /firmware/App/Controllers/LoadCell.c
    • -3
    • +3
    /firmware/App/Controllers/ROPump.c
    • -0
    • +4
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeService.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -23
    • +10
    /firmware/App/Services/FPGA.c
    • -7
    • +7
    /firmware/App/Services/Reservoirs.c
5:03 pm

Dara Navaei

This was defined in DEN-13460.

This was defined in DEN-13460.

5:02 pm

Dara Navaei

Each of these functions are used twice.

Each of these functions are used twice.

4:42 pm

Dara Navaei

Done.

Done.

4:34 pm

Dara Navaei

Done.

Done.

4:31 pm

Dara Navaei

Done.

Done.

4:31 pm

Dara Navaei

We do not update the variables if the if they do not meet the conditions.

We do not update the variables if the if they do not meet the conditions.

3:51 pm

Dara Navaei

Done.

Done.

3:50 pm

Dara Navaei

Done. We usually define the state at the top so for consistency, I defined the state first.

Done. We usually define the state at the top so for consistency, I defined the state first.

3:48 pm

Dara Navaei

Done.

Done.

3:47 pm

Dara Navaei

Done.

Done.

3:44 pm

Dara Navaei

Done.

Done.

3:43 pm

Dara Navaei

Done.

Done.

3:42 pm

Dara Navaei

These have been fixed in DEN-13460.

These have been fixed in DEN-13460.

3:40 pm

Dara Navaei

Done.

Done.

3:37 pm

Dara Navaei

Done.

Done.

3:36 pm

Dara Navaei

Done.

Done.

3:35 pm

Dara Navaei

This function covers both DVT and V3 and depending on the status it pick the conversion coefficients.

This function covers both DVT and V3 and depending on the status it pick the conversion coefficients.

3:34 pm

Dara Navaei

Done.

Done.

3:33 pm

Dara Navaei

Done.

Done.

3:32 pm

Dara Navaei

This is a temporary number and has been removed in DEN-13460.

This is a temporary number and has been removed in DEN-13460.

3:31 pm

Dara Navaei

Done.

Done.

3:30 pm

Dara Navaei

This issue will be addressed in DEN-13460.

This issue will be addressed in DEN-13460.

3:29 pm

Dara Navaei

Done.

Done.

3:26 pm

Dara Navaei

Done.

Done.

2:42 pm

Dara Navaei

Done.

Done.

2:41 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

Removed the banner.

Removed the banner.

2:38 pm

Dara Navaei

Done.

Done.