dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 31 Aug 2022
5:08 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

Options
    • -2
    • +1
    /firmware/App/Controllers/Heaters.c
5:06 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13786 DEN-13573 Correct MIN_INLET_TEMPERATURE_C value and minor logic bug. DEN-13786 DEN-13582 Delta temperature calculation requires fabs.

Options
    • -2
    • +1
    /firmware/App/Controllers/Heaters.c
    • -4
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
4:22 pm

wbracken  (deleted user)

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

2:43 pm

Dara Navaei

DEN-13460 addressed the code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/DialysateFlow.c
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
2:42 pm

Dara Navaei

This code is un-commented.

This code is un-commented.

2:41 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

In in DEN-13834.

In in DEN-13834.

2:38 pm

Dara Navaei

Done.

Done.

2:37 pm

Dara Navaei

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

2:35 pm

Dara Navaei

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

2:33 pm

Dara Navaei

Done.

Done.

9:27 am

Dara Navaei

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2

Options
9:27 am

Dara Navaei

DEN-13460 updated the heaters driver. Moved the heaters data broadcast structure to the fwcommon so the HD can use it too. Updated the temperature sensors FPGA persistent alarm

Options
    • -12
    • +9
    /firmware/App/Controllers/Heaters.c
    • -15
    • +0
    /firmware/App/Controllers/Heaters.h
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -70
    • +49
    /firmware/App/Controllers/TemperatureSensors.c
Tuesday 30 Aug 2022
6:04 pm

Dara Navaei

Done.

Done.

3:12 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:10 pm

Michael Garthwaite

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

Options
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.h
3:10 pm

Michael Garthwaite

DEN-13427: DIAL-201. Updated temp sensors broadcast message to include thd RTD.

Options
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.h
3:03 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

Options
    • -1
    • +6
    /firmware/App/Controllers/TemperatureSensors.c
2:53 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13786 DEN-13770 The persistent alarm interface was changed resulting in the immediate turning off of the UVReactors. Changed to correct function call. DEN-13786 DEN-13558 Correct getRsrvrDrainStatus and getRsrvrFillStatus per modes to Flush mode

Options
    • -2
    • +2
    /firmware/App/Controllers/UVReactors.c
    • -4
    • +24
    /firmware/App/Modes/ModeHeatDisinfect.c
2:33 pm

Sean Nash

DEN-13460: make boolean explicit, update function header.

Options
    • -1
    • +3
    /firmware/App/Controllers/LoadCell.c
10:21 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:21 am

Dara Navaei

Commented out alarm 196

Options
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
Monday 29 Aug 2022
5:08 pm

wbracken  (deleted user)

Align on "*" maybe?

Align on "*" maybe?

4:38 pm

wbracken  (deleted user)

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

4:31 pm

wbracken  (deleted user)

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

3:57 pm

wbracken  (deleted user)

Set "status" to FALSE.

Set "status" to FALSE.

3:51 pm

wbracken  (deleted user)

Should this be removed?

Should this be removed?

3:47 pm

wbracken  (deleted user)

Should variables in if be reversed?

Should variables in if be reversed?

3:42 pm

wbracken  (deleted user)

Should this be in or not?

Should this be in or not?