dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

DEN-13786 DEN-13573 Correct MIN_INLET_TEMPERATURE_C value and minor logic bug. DEN-13786 DEN-13582 Delta temperature calculation requires fabs.

    • -4
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

DEN-13460 addressed the code review comments

    • -1
    • +1
    /firmware/App/Controllers/DialysateFlow.c
This code is un-commented.

This code is un-commented.

Done.

Done.

In in DEN-13834.

In in DEN-13834.

Done.

Done.

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

Done.

Done.

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2

DEN-13460 updated the heaters driver. Moved the heaters data broadcast structure to the fwcommon so the HD can use it too. Updated the temperature sensors FPGA persistent alarm

    • -12
    • +9
    /firmware/App/Controllers/Heaters.c
    • -15
    • +0
    /firmware/App/Controllers/Heaters.h
Done.

Done.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

DEN-13427: DIAL-201. Updated temp sensors broadcast message to include thd RTD.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

DEN-13786 DEN-13770 The persistent alarm interface was changed resulting in the immediate turning off of the UVReactors. Changed to correct function call. DEN-13786 DEN-13558 Correct getRsrvrDrainStatus and getRsrvrFillStatus per modes to Flush mode

    • -2
    • +2
    /firmware/App/Controllers/UVReactors.c
    • -4
    • +24
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-13460: make boolean explicit, update function header.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Commented out alarm 196

Align on "*" maybe?

Align on "*" maybe?

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

Set "status" to FALSE.

Set "status" to FALSE.

Should this be removed?

Should this be removed?

Should variables in if be reversed?

Should variables in if be reversed?

Should this be in or not?

Should this be in or not?