dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Oct 2022
1:06 pm

Dara Navaei

DEN-13834 addressed the code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/Fans.c
    • -11
    • +17
    /firmware/App/Controllers/FlowSensors.c
    • -2
    • +1
    /firmware/App/Controllers/FlowSensors.h
    • -17
    • +21
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -4
    • +2
    /firmware/App/Controllers/UVReactors.c
    • -3
    • +3
    /firmware/App/Controllers/Voltages.h
    • -1
    • +0
    /firmware/App/DGCommon.h
    • -0
    • +4
    /firmware/App/Modes/ModeFault.c
    • -3
    • +3
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
    • -8
    • +4
    /firmware/App/Services/SystemComm.c
    • -2
    • +1
    /firmware/App/Services/SystemCommMessages.c
1:05 pm

Dara Navaei

Done.

Done.

1:04 pm

Dara Navaei

Removed the #define.

Removed the #define.

11:21 am

Sean Nash

Remove #ifndef and remove the center condition (msgID <= END_OF_MSG_IDS -1).

Remove #ifndef and remove the center condition (msgID <= END_OF_MSG_IDS -1).

10:55 am

Dara Navaei

Done.

Done.

10:53 am

Dara Navaei

Done.

Done.

10:52 am

Dara Navaei

Done.

Done.

10:52 am

Dara Navaei

This is part of the SRSs. This alarm is uncommented and is running.

This is part of the SRSs. This alarm is uncommented and is running.

10:51 am

Dara Navaei

Done.

Done.

10:47 am

Dara Navaei

Done.

Done.

10:46 am

Dara Navaei

This is not called in the ModeInitPOST. Right now, it does not do anything.

This is not called in the ModeInitPOST. Right now, it does not do anything.

10:43 am

Dara Navaei

Done.

Done.

10:42 am

Dara Navaei

Done.

Done.

10:42 am

Dara Navaei

Done.

Done.

10:41 am

Dara Navaei

Done.

Done.

10:40 am

Dara Navaei

Please see the comments.

Please see the comments.

10:35 am

Dara Navaei

Done.

Done.

10:15 am

Dara Navaei

Done.

Done.

10:14 am

Dara Navaei

Done.

Done.

10:14 am

Dara Navaei

Done.

Done.

10:13 am

Dara Navaei

Done.

Done.

10:12 am

Dara Navaei

These are implemented like HD is implemented.

These are implemented like HD is implemented.

10:01 am

Dara Navaei

Done.

Done.

9:58 am

Dara Navaei

Done.

Done.

9:52 am

Dara Navaei

For the overrides, if the sensor is not in range, the command is just ignored.

For the overrides, if the sensor is not in range, the command is just ignored.

9:52 am

Dara Navaei

For the overrides, if the sensor is not in range, the command is just ignored.

For the overrides, if the sensor is not in range, the command is just ignored.

9:51 am

Sean Nash

But, since there is not loop, you can arrange default to be reached in vectorcast - so no need to have #ifndef.

But, since there is not loop, you can arrange default to be reached in vectorcast - so no need to have #ifndef.

9:49 am

Sean Nash

I guess what I'm asking is - can loops be combined? Is there any reason not to convert and monitor each sensor before moving to next?

I guess what I'm asking is - can loops be combined? Is there any reason not to convert and monitor each sensor before moving to next?

9:46 am

Dara Navaei

Done.

Done.

9:46 am

Dara Navaei

Done.

Done.