dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged staging

Removed.

Removed.

Removed.

Removed.

Removed

Removed

Change was made to get around earlier issues. Need discussion on whether or not to change back.

Change was made to get around earlier issues. Need discussion on whether or not to change back.

This build switch has been removed.

This build switch has been removed.

Merge branch 'staging' into DEN-13786-hd_dg_dev-s78_bb

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

# firmware/App/Controllers/Heaters.c

# firmware/App/Controllers/ROPump.c

# firmware/App/Controllers/UVReactors.c

# firmware/App/Modes/ModeHeatDisinfect.c

    • -16
    • +16
    /firmware/App/Controllers/ROPump.c
    • -7
    • +26
    /firmware/App/Modes/ModeHeatDisinfect.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Why is RTC POST disabled?

Why is RTC POST disabled?

Remove extra blank line.

Remove extra blank line.

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

Is this dead code? Can we remove?

Is this dead code? Can we remove?

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

Alphabetize (move toward top of includes).

Alphabetize - move toward top of includes.

Alphabetize - move toward top of includes.

Magic #?

Magic #?

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

In V3, when TRo is requested, the firmware send the value of TDi.

In V3, when TRo is requested, the firmware send the value of TDi.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This is not a software fault. This has been addressed in DEN-14166.

This is not a software fault. This has been addressed in DEN-14166.

Should use of TRo here be for DVT (if V3 s/w config, continue to use TDi)?

Should use of TRo here be for DVT (if V3 s/w config, continue to use TDi)?

Can we do s/w fault now?

Can we do s/w fault now?

Remove comment.

Remove comment.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-13768 Remove EMC build from ROPump. Don not set cancellationMode when exiting DG_HEAT_DISINFECT_STATE_COOL_DOWN_RO_FILTER.

    • -1
    • +0
    /firmware/App/Modes/ModeHeatDisinfect.c