Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 03 Nov 2022

3:53 pm

Dara Navaei

More
8e0041d
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 added trimmer heater use last duty cycle to the broadcast data

- -4
- +5
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

3:30 pm

Dara Navaei

More
Re: DG-DEN-14237-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
25cf37f
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more DG-DEN-14237-1

DEN-14237 Correct multipe changes to return status based upon whether or not there is a pending alarm.

- -65
- +82
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

2:13 pm

Dara Navaei

More
Re: DG-DEN-14237-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed

Removed

2:07 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed

Removed

2:06 pm

wbracken (deleted user)

This else has been removed

This else has been removed

2:05 pm

wbracken (deleted user)

Removed

Removed

2:04 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed

Removed

2:04 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed

Removed

2:03 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed

Removed

2:03 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed

Removed

2:02 pm

wbracken (deleted user)

More
Re: DG-DEN-14237-1
replied to Sean Nash

Removed. Intended to remove all along.

Removed. Intended to remove all along.

1:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
1c4e4a0
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more DG-DEN-14237-1

DEN-14237 Removed conditional code and references to isThisLastDrain.

- -302
- +24
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

1:44 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Remove references to this flag.

Remove references to this flag.

1:41 pm

Dara Navaei

More
Re: DG-DEN-14237-1
commented on review

This function will still override if there any alarms. Are we going to change the order of status report?

This function will still override if there any alarms. Are we going to change the order of status report?

1:40 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Remove the TRUE case. Just need the else now.

Remove the TRUE case. Just need the else now.

1:40 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Remove TRUE case. Just need the else now.

Remove TRUE case. Just need the else now.

1:39 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Remove this flag.

Remove this flag.

1:38 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Let's remove this code.

Let's remove this code.

1:37 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Can we remove this code?

Can we remove this code?

1:37 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Can we just remove this code?

Can we just remove this code?

1:37 pm

Dara Navaei

More
Re: DG-DEN-14237-1
commented on review

This flag also should be removed.

This flag also should be removed.

1:37 pm

Sean Nash

More
Re: DG-DEN-14237-1
commented on review

Can we just remove these?

Can we just remove these?

1:26 pm

Dara Navaei

More
DG-DEN-14237-1
started review

DG-DEN-14237_Remove Heat Disinfect Rinse States

DG-DEN-14237_Remove Heat Disinfect Rinse States

10:56 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
e056d72
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more DG-UCOMMITS-38

DEN-14237 changes to getHeatDisinfectStatus.

- -4
- +4
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

10:37 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:32 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:29 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:03 am

Dara Navaei

More
6f29912
changed 17 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DG-DEN-14175-1

DEN-14175 addressed the code review comments and replaced the V3 enable software configuration flag with the hardware configuration flag from FGPA. Updated the trimmer heater's ramp state to check the use previous duty cycle flag instead of estimating the duty cycle.

- -4
- +5
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -1
- +1
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -5
- +6
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -1
- +1
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c
- -7
- +30
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -0
- +2
/firmware/App/Controllers/Heaters.h
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.h
- -9
- +7
/firmware/App/Controllers/Pressures.c
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.c
- -1
- +2
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -9
- +5
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -1
- +2
/firmware/App/Controllers/Thermistors.c
- History
- Source
- Diff
/firmware/App/Controllers/Thermistors.c
- -9
- +71
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -1
- +3
/firmware/App/Controllers/Valves.h
- History
- Source
- Diff
/firmware/App/Controllers/Valves.h
- -3
- +4
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -0
- +1
/firmware/App/Modes/ModeFill.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.h
- -2
- +2
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -1
- +2
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c
- -6
- +7
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-19 20:49 -0700