dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Alignment

Alignment

Do we need a maximum? If so, magic number.

Do we need a maximum? If so, magic number.

Invalid step limit (not signal)?

Invalid step limit (not signal)?

We are changing the step limit on a control so I would expect an output.

We are changing the step limit on a control so I would expect an output.

Remove signalID and add stepLimit as params.

Remove signalID and add stepLimit as params.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes and no for the place holder. The profiles expected to change in the future. They may have different load states but for now we have tuned Kp and Ki along with our maximum PWM step limit to get ...

Yes and no for the place holder. The profiles expected to change in the future. They may have different load states but for now we have tuned Kp and Ki along with our maximum PWM step limit to get the level of responsiveness we wanted to achieve with this optimization task. We can further fine tune the pump profiles with this data structure if necessary. setROPIFlowProfile will be called in when we transition operation modes when we intend to differentiate between profiles.

Remove blank line.

Remove blank line.

Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.

Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.

Alignment

Alignment

Remove blank line

Remove blank line

Alignment

Alignment

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!