dgfirmware

Clone Tools

Stats

Commits this week: 1
Total Committers: 17
Last Commit: 07 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
2:27 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -18
    • +18
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
2:26 pm

Sean Nash

This line of code is not referencing a field in a structure. I do not see it declared anywhere. I've been unable to build this branch (I think because there is no fwcommon branch) so somebody may h...

This line of code is not referencing a field in a structure. I do not see it declared anywhere. I've been unable to build this branch (I think because there is no fwcommon branch) so somebody may have fixed this in develop.

2:23 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:23 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:22 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:21 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:21 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:20 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:20 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:20 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:20 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:19 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -5
    • +6
    /firmware/App/Services/PIControllers.c
2:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:18 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:18 pm

Sean Nash

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

2:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

wbracken  (deleted user)

Alignment

Alignment

2:10 pm

Sean Nash

Do we need a maximum? If so, magic number.

Do we need a maximum? If so, magic number.

2:09 pm

Sean Nash

Invalid step limit (not signal)?

Invalid step limit (not signal)?

2:07 pm

Sean Nash

We are changing the step limit on a control so I would expect an output.

We are changing the step limit on a control so I would expect an output.

2:06 pm

Sean Nash

Remove signalID and add stepLimit as params.

Remove signalID and add stepLimit as params.

2:04 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:04 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:04 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -17
    • +8
    /firmware/App/Services/PIControllers.c
    • -1
    • +0
    /firmware/App/Services/PIControllers.h
2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.