Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 20 Dec 2022

12:44 pm

Steve Jarpe <sjarpe@diality.com>

More
2bb8d48
changed 7 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14316-1

DEN-14316-chemical-disinfect. Merged code walkthrough changes and my code review changes.

- -33
- +34
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -33
- +31
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -2
- +1
/firmware/App/Modes/ModeChemicalDisinfectFlush.h
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.h
- -3
- +3
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +1
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -1
- +1
/firmware/App/Services/PIControllers.h
- History
- Source
- Diff
/firmware/App/Services/PIControllers.h
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

12:40 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

The start_stop messages for other modes are named similarly.

The start_stop messages for other modes are named similarly.

12:35 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

removed

removed

12:35 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

removed

removed

12:29 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

fixed

fixed

12:28 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

fixed

fixed

12:25 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

Fixed

Fixed

12:21 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

fixed

fixed

12:19 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

fixed

fixed

12:17 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

I need help with resolving this.

I need help with resolving this.

12:08 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

I am still not sure where you want the declarations to go. They are just before the part of the function that checks the inlet water conditions. The only other logical place is at the top.

I am still not sure where you want the declarations to go. They are just before the part of the function that checks the inlet water conditions. The only other logical place is at the top.

12:01 pm

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to Sean Nash

Removed the do nothing cases, added comment to default case.

Removed the do nothing cases, added comment to default case.

11:57 am

Steve Jarpe

More
Re: DG-DEN-14316-1
replied to wbracken (deleted user)

Fixed

Fixed

11:03 am

Sean Nash

More
DG-DEN-14403-1
finished reviewing

11:01 am

Steve Jarpe <sjarpe@diality.com>

More
3f19c30
changed 4 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14316-1

DEN-14316-chemical-disinfect. Changes for code review

- -35
- +40
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -25
- +24
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -1
- +17
/firmware/App/Modes/ModeChemicalDisinfectFlush.h
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.h
- -0
- +1
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h

10:36 am

Dara Navaei

More
329409d
changed 2 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14307-1

DEN-14307 updated the concentrate pumps park command

- -21
- +55
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -32
- +24
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

10:02 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of co...

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of code unless there is a good reason (e.g. a dependency in assignment on code above).

9:59 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

More
d63cef4
changed 1 file
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more DG-DEN-14316-1

DEN-14316: Replaced tabs with 4 spaces per code review.

- -32
- +32
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c

9:52 am

Sean Nash

More
Re: DG-DEN-14316-1
commented on review

Align "="s.

Align "="s.

9:51 am

Sean Nash

More
Re: DG-DEN-14316-1
commented on review

Alignment - why is "=" pushed out so far?

Alignment - why is "=" pushed out so far?

9:46 am

Sean Nash

More
Re: DG-DEN-14316-1
commented on review

Align "="s.

Align "="s.

9:45 am

Sean Nash

More
Re: DG-DEN-14316-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-08 08:39 -0700