dgfirmware

Clone Tools

Stats

Commits this week: 9
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Dec 2022
4:11 pm

Sean Nash

DEN-14307: Addressed code review comments.

Options
    • -0
    • +3
    /firmware/App/Controllers/ConcentratePumps.h
    • -4
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -3
    • +0
    /firmware/App/Modes/ModeFault.h
    • -5
    • +5
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenIdle.c
    • -6
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +1
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
    • -2
    • +3
    /firmware/App/Modes/ModeService.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
4:11 pm

Steve Jarpe

Removed it this time.

Removed it this time.

4:11 pm

Steve Jarpe

OK, now I see. I removed this one. There are others, should I remove them also?

OK, now I see. I removed this one. There are others, should I remove them also?

3:59 pm

Steve Jarpe

Done

Done

3:42 pm

Steve Jarpe

The declarations have been moved higher, as in ModeChemicalDisinfectFlush

The declarations have been moved higher, as in ModeChemicalDisinfectFlush

3:41 pm

Steve Jarpe

The lines have been moved.

The lines have been moved.

3:40 pm

Steve Jarpe

removed

removed

3:34 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:33 pm

Sean Nash

Need default case with s/w fault.

Need default case with s/w fault.

3:30 pm

Steve Jarpe

Fixed

Fixed

3:29 pm

Sean Nash

Need a default case with s/w fault.

Need a default case with s/w fault.

3:28 pm

Sean Nash

Need a default case w/ s/w fault.

Need a default case w/ s/w fault.

3:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:27 pm

Sean Nash

Alignment.

Alignment.

3:26 pm

Sean Nash

Add a comment to explain why this is here.

Add a comment to explain why this is here.

3:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:29 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:18 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:17 pm

wbracken  (deleted user)

Remove blank line.

Remove blank line.

2:14 pm

wbracken  (deleted user)

Should these two lines be deleted?

Should these two lines be deleted?

2:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:09 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:06 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:06 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:05 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:59 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:59 pm

wbracken  (deleted user)

Remove blank lines.

Remove blank lines.

1:58 pm

Sean Nash

DEN-14316: Addressed code review comments.

Options
    • -2
    • +3
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -2
    • +0
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -4
    • +0
    /firmware/App/Modes/ModeStandby.c