dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Dec 2022
5:18 pm

Steve Jarpe <sjarpe@diality.com>

/DEN-14316-chemical-disinfect. Code review changes

Options
    • -21
    • +5
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -18
    • +4
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -7
    • +12
    /firmware/App/Modes/ModeStandby.c
5:17 pm

Steve Jarpe

OK I see the space.

OK I see the space.

5:17 pm

Steve Jarpe

Actually they are used.

Actually they are used.

5:14 pm

wbracken  (deleted user)

I'll assume this has been fixed but not pushed since it still shows up here.

I'll assume this has been fixed but not pushed since it still shows up here.

5:13 pm

wbracken  (deleted user)

Before the beginning /* Sean asked me to update your branch. I have modifications to 3 files which I believe address most of my comments. I can push my changes if that helps.

Before the beginning /*

Sean asked me to update your branch. I have modifications to 3 files which I believe address most of my comments. I can push my changes if that helps.

5:10 pm

wbracken  (deleted user)

Does not appear to be used.

Does not appear to be used.

5:09 pm

wbracken  (deleted user)

Does not appear to be referenced.

Does not appear to be referenced.

5:09 pm

Sean Nash

I'll have Dara do it once this branch is closed. It's a small thing on HD side to manage some UI interactions.

I'll have Dara do it once this branch is closed. It's a small thing on HD side to manage some UI interactions.

5:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:01 pm

Steve Jarpe

I can't find this.

I can't find this.

5:00 pm

Sean Nash

This message clearly has a payload - we should check payload length to be whatever it is.

This message clearly has a payload - we should check payload length to be whatever it is.

4:57 pm

Steve Jarpe

removed

removed

4:57 pm

Steve Jarpe

removed

removed

4:47 pm

Steve Jarpe

removed

removed

4:44 pm

Sean Nash

Need a default case w/ comment stating status already set to TRUE for all other modes.

Need a default case w/ comment stating status already set to TRUE for all other modes.

4:44 pm

Steve Jarpe

removed

removed

4:43 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

4:42 pm

Sean Nash

Should not be able to transition from heat disinfect cool to chem disinfect cool.

Should not be able to transition from heat disinfect cool to chem disinfect cool.

4:41 pm

Sean Nash

Should not be able to transition from fault to either new mode.

Should not be able to transition from fault to either new mode.

4:40 pm

Steve Jarpe

done

done

4:23 pm

Sean Nash

Remove blank lines. If nothing in else, remove else.

Remove blank lines. If nothing in else, remove else.

4:21 pm

Sean Nash

Remove blank line.

Remove blank line.

4:19 pm

Sean Nash

This kind of temporary test change should probably not be committed. Just do locally in lab so reviewers don't see it and no chance that it stays this way.

This kind of temporary test change should probably not be committed. Just do locally in lab so reviewers don't see it and no chance that it stays this way.

4:17 pm

Steve Jarpe

Actually the only other place I could put them is at the top of the function.

Actually the only other place I could put them is at the top of the function.

4:16 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:14 pm

Steve Jarpe

removed

removed

4:13 pm

Steve Jarpe

Not sure.

Not sure.

4:13 pm

Steve Jarpe

I am not sure what should be done.

I am not sure what should be done.