dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Dec 2022
10:39 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle

Options
10:02 am

Steve Jarpe

This may be from an older version?

This may be from an older version?

9:56 am

Sean Nash

I don't understand the question. Appears to be publishing data now.

I don't understand the question. Appears to be publishing data now.

9:55 am

Steve Jarpe

removed

removed

9:55 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Steve Jarpe

I don't know the answer to this question.

I don't know the answer to this question.

9:49 am

Steve Jarpe

I don't see what needs to be updated.

I don't see what needs to be updated.

9:48 am

Steve Jarpe

Could you be more specific? It looks correct to me.

Could you be more specific? It looks correct to me.

9:46 am

Steve Jarpe

removed

removed

9:45 am

Steve Jarpe

chemDisinfectFlushUIState is set in a number of places, but it was not set in the publish logging data function. I corrected that.

chemDisinfectFlushUIState is set in a number of places, but it was not set in the publish logging data function. I corrected that.

9:33 am

Steve Jarpe

I went through it again, and changed a number of them.

I went through it again, and changed a number of them.

9:21 am

Steve Jarpe

R1ChemDisinfectVol and "R2ChemDisinfectVol have been removed from ModeChemicalDisinfect.c

R1ChemDisinfectVol and "R2ChemDisinfectVol have been removed from ModeChemicalDisinfect.c

9:18 am

Steve Jarpe

The UI state is set to CHEM_DISINFECT_UI_STATE_DISINFECT_DEVICE when the disinfectant is being added to the reservoirs. It is one of the logged parameters. This was in the original chem disinfect c...

The UI state is set to CHEM_DISINFECT_UI_STATE_DISINFECT_DEVICE when the disinfectant is being added to the reservoirs. It is one of the logged parameters. This was in the original chem disinfect code.

8:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:36 am

Sean Nash

Leaving as is for now. Will review all msg IDs later. RESOLVED in CODE WALKTHROUGH.

Leaving as is for now. Will review all msg IDs later.
RESOLVED in CODE WALKTHROUGH.

8:34 am

Sean Nash

Added to group. RESOLVED in CODE WALKTHROUGH.

Added to group.
RESOLVED in CODE WALKTHROUGH.

8:30 am

Sean Nash

Ok as is. RESOLVED in CODE WALKTHROUGH.

Ok as is.
RESOLVED in CODE WALKTHROUGH.

8:09 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:05 am

Sean Nash

Where is UI state used?

Where is UI state used?

Tuesday 20 Dec 2022
6:54 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. Code review changes.

Options
    • -9
    • +3
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -9
    • +8
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
6:52 pm

wbracken  (deleted user)

Remove blank line.

Remove blank line.

6:48 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:48 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:47 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:46 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:45 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:43 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:42 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:38 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

6:37 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.