dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Dec 2022
6:32 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. Code review changes

Options
    • -35
    • +34
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -10
    • +10
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
3:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.h
    • -1
    • +1
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -2
    • +2
    /firmware/App/Modes/ModeFault.c
    • -2
    • +2
    /firmware/App/Modes/ModeFault.h
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
  16. … 12 more files in changeset.
3:02 pm

Dara Navaei

2:57 pm

wbracken  (deleted user) and Sean Nash

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTRHOUGH.

RESOLVED IN CODE WALKTRHOUGH.

2:55 pm

Dara Navaei

These two variables are local.

These two variables are local.

2:52 pm

wbracken  (deleted user)

Add concCap and diaCap to header.

Add concCap and diaCap to header.

2:44 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

2:30 pm

Dara Navaei

Merged staging

Options
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -67
    • +186
    /firmware/App/Controllers/ROPump.c
    • -1302
    • +856
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -0
    • +1073
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -10
    • +69
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
    • -4
    • +4
    /firmware/App/Modes/ModeGenIdle.c
    • -4
    • +7
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -4
    • +63
    /firmware/App/Modes/ModeStandby.c
    • -3
    • +4
    /firmware/App/Modes/ModeStandby.h
    • -2
    • +11
    /firmware/App/Modes/OperationModes.c
    • -8
    • +13
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +4
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -5
    • +25
    /firmware/App/Services/SystemComm.c
    • -36
    • +288
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +21
    /firmware/App/Services/SystemCommMessages.h
1:40 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:40 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -5
    • +5
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -5
    • +5
    /firmware/App/Modes/ModeChemicalDisinfectFlush.h
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.h
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    /firmware/App/Services/PIControllers.h
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
1:36 pm

Dara Navaei

1:32 pm

Sean Nash

1:24 pm

Dara Navaei

DEN-14316 merged staging

Options
    • -2
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +4
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -2
    • +14
    /firmware/App/Services/PIControllers.h
    • -5
    • +21
    /firmware/App/Services/SystemComm.c
    • -46
    • +262
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +20
    /firmware/App/Services/SystemCommMessages.h
1:19 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:19 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/Voltages.c
1:18 pm

Dara Navaei

1:17 pm

Dara Navaei

Merge branch 'staging' into DEN-14403-dg-voltages-alarm-77-not-triggered

Options
1:05 pm

Dara Navaei

DEN-14307 addressed the code review comment

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
1:04 pm

Dara Navaei

Done

Done

1:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:52 pm

Sean Nash

DEN-14316: Addressed code review comments.

Options
    • -5
    • +6
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:48 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:13 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

12:12 pm

wbracken  (deleted user)

Should add alarmDetectedPendingTrigger and preFlushState.

Should add alarmDetectedPendingTrigger and preFlushState.

12:10 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.