dgfirmware

Clone Tools

Stats

Commits this week: 9
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Feb 2023
10:08 am

Dara Navaei

DEN-14604 addressed the code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/UVReactors.c
    • -24
    • +19
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -19
    • +18
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +2
    /firmware/App/Services/SystemCommMessages.c
10:07 am

Dara Navaei

Done

Done

10:01 am

Dara Navaei

Done

Done

9:46 am

Dara Navaei

No this has been removed.

No this has been removed.

9:45 am

Dara Navaei

Removed the code.

Removed the code.

9:45 am

Dara Navaei

Removed the code.

Removed the code.

9:44 am

Dara Navaei

Removed the code.

Removed the code.

9:43 am

Dara Navaei

Done.

Done.

9:29 am

Sean Nash

Missing break?

Missing break?

9:22 am

Sean Nash

Shouldn't this just be an if (not an else if)? If both are unhealthy, we should activate both alarms, right?

Shouldn't this just be an if (not an else if)? If both are unhealthy, we should activate both alarms, right?

9:19 am

Sean Nash

Will this get picked up by doxygen? Do we want that? If not, maybe put this structure outside of the heat disinfect grouping.

Will this get picked up by doxygen? Do we want that? If not, maybe put this structure outside of the heat disinfect grouping.

9:15 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:11 am

Sean Nash

I think #defines are still appropriate. Since it's debug code, they can be placed right above the function (inside the #ifndef RELEASE) so they do not get used in release s/w.

I think #defines are still appropriate. Since it's debug code, they can be placed right above the function (inside the #ifndef RELEASE) so they do not get used in release s/w.

9:02 am

Dara Navaei

Merge branch 'staging' into DEN-14604-dg_hd_dev-hd_dg_dvt-update-part-9

Options
    • -4
    • +5
    /firmware/App/Controllers/Pressures.c
    • -6
    • +4
    /firmware/App/Modes/ModeFill.c
    • -3
    • +6
    /firmware/App/Modes/ModeStandby.c
8:59 am

Dara Navaei

DEN-14604 added comments

Options
    • -0
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -0
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.c
8:51 am

Dara Navaei

DEN-14604 added Nelson labs heat disinfect positive control mode

Options
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -0
    • +7
    /firmware/App/Modes/ModeFault.c
    • -32
    • +57
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -1
    • +4
    /firmware/App/Modes/ModeStandby.c
    • -4
    • +10
    /firmware/App/Services/SystemCommMessages.c
8:36 am

Dara Navaei

Done.

Done.

8:35 am

Dara Navaei

Let's keep this broadcast until this project is finished.

Let's keep this broadcast until this project is finished.

8:34 am

Dara Navaei

Done.

Done.

8:31 am

Dara Navaei

Removed the code.

Removed the code.

8:27 am

Dara Navaei

Done

Done

8:25 am

Dara Navaei

Done.

Done.

8:25 am

Dara Navaei

Done

Done

8:24 am

Dara Navaei

This include is no longer needed.

This include is no longer needed.

8:23 am

Dara Navaei

These values are temporary and only when we build a debug code. So I prefer not to have a #define for them.

These values are temporary and only when we build a debug code. So I prefer not to have a #define for them.