dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Controllers/UVReactors.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14604 added VectorCAST from PiSquare and addressed code review comments

    • -29
    • +27
    /firmware/App/Modes/ModeHeatDisinfect.c
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

The enum comments are now non-doxygen style, but the enum is still in the group. Move it below the /*@}/ to get it out of HeatersState group.

The enum comments are now non-doxygen style, but the enum is still in the group. Move it below the /*@}/ to get it out of HeatersState group.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Shouldn't this one stay "MIN"?

Shouldn't this one stay "MIN"?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14604 addressed the code review comments

    • -1
    • +1
    /firmware/App/Controllers/UVReactors.c
    • -24
    • +19
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -19
    • +18
    /firmware/App/Modes/ModeHeatDisinfect.c
Done

Done

Done

Done

No this has been removed.

No this has been removed.

Removed the code.

Removed the code.

Removed the code.

Removed the code.

Removed the code.

Removed the code.

Done.

Done.

Missing break?

Missing break?