dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Feb 2023
1:40 pm

Michael Garthwaite

DEN-14547: Addressing code review comments.

Options
    • -7
    • +6
    /firmware/App/Modes/OperationModes.c
1:37 pm

Michael Garthwaite

transitionToNewOperationMode() is currently void. This would have to change to returning the submode enum. This was an issue found in testing the events that we miss the event transition from going...

transitionToNewOperationMode() is currently void. This would have to change to returning the submode enum. This was an issue found in testing the events that we miss the event transition from going to new modes and needed the code change down at line ~380.

Do we want to change transitionToNewOperationMode() to return sub mode?

1:25 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:08 pm

Sean Nash

1:03 pm

Sean Nash

Fixed merge conflict.

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
1:03 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
Sunday 05 Feb 2023
1:17 pm

Dara Navaei

DEN-14749 fixed the exit status of the Nelson labs heat disinfect positive control mode

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
7:01 am

Dara Navaei

DG-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
DG-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
Saturday 04 Feb 2023
3:34 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:19 pm

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +21
    /firmware/App/Controllers/ConductivitySensors.c
    • -7
    • +21
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Modes/ModeFill.c
    • -0
    • +6
    /firmware/App/Services/SystemComm.c
    • -0
    • +64
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +5
    /firmware/App/Services/SystemCommMessages.h
2:44 pm

Sean Nash

Add currentMode, currentSubMode to inputs and outputs

Add currentMode, currentSubMode to inputs and outputs

2:42 pm

Sean Nash

currentSubMode is an input now.

currentSubMode is an input now.

2:41 pm

Sean Nash

Restore this blank line.

Restore this blank line.

2:40 pm

Sean Nash

Should currentSubMode be assigned to return value here?

Should currentSubMode be assigned to return value here?

2:38 pm

Sean Nash

Move blank line from before to after declaration.

Move blank line from before to after declaration.

2:36 pm

Sean Nash

Remove blank lines.

Remove blank lines.

Friday 03 Feb 2023
3:01 pm

Dara Navaei

DG-DEN-14646_Fpga Alarm Properties And Timing 3
DG-DEN-14646_Fpga Alarm Properties And Timing 3
3:01 pm

Dara Navaei

DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
1:48 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:48 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.h
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/UVReactors.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.h
    • -2
    • +2
    /firmware/App/Modes/ModeFault.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
1:47 pm

Dara Navaei

12:51 pm

Sean Nash and wbracken  (deleted user)

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:12 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:07 am

Dara Navaei

DEN-14604 added VectorCAST from PiSquare and addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -0
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -29
    • +27
    /firmware/App/Modes/ModeHeatDisinfect.c
10:55 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

Done

Done

10:32 am

Dara Navaei

Done

Done