Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 07 Feb 2023

7:53 am

Michael Garthwaite

More
7b88c90
changed 3 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 156 more DG-DEN-14589-1

Merge branch 'staging' into DEN-14589-DIAL-211

- -1
- +7
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -1
- +65
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -1
- +6
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

Monday 06 Feb 2023

4:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
4eb225a
changed 0 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 138 more

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

2:14 pm

Sean Nash

More
DG-DEN-14547-1
finished reviewing

2:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

You're right. RESOLVED in CODE WALKTHROUGH.

You're right.
RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:47 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:45 pm

Michael Garthwaite

More
990b4e3
changed 0 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 160 more

Merge branch 'staging' into DEN-14547-incorrect-dg-event

1:41 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:41 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:41 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to wbracken (deleted user)

Fixed. Thanks!

Fixed. Thanks!

1:41 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:41 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:41 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:40 pm

Michael Garthwaite

More
4bc08dc
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 160 more DG-DEN-14547-1

DEN-14547: Addressing code review comments.

- -7
- +6
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c

1:37 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

transitionToNewOperationMode() is currently void. This would have to change to returning the submode enum. This was an issue found in testing the events that we miss the event transition from going...

transitionToNewOperationMode() is currently void. This would have to change to returning the submode enum. This was an issue found in testing the events that we miss the event transition from going to new modes and needed the code change down at line ~380.

Do we want to change transitionToNewOperationMode() to return sub mode?

1:25 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

1:08 pm

Sean Nash

More
DG-DEN-14749-1
Closed

1:03 pm

Sean Nash

Fixed merge conflict.

- -1
- +1
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -1
- +1
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -1
- +1
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

1:03 pm

Dara Navaei

More
2a626cf
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 160 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

1:03 pm

Dara Navaei

More
8d83193
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 160 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

Sunday 05 Feb 2023

1:17 pm

Dara Navaei

More
2fc107b
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 161 more DG-DEN-14749-1

DEN-14749 fixed the exit status of the Nelson labs heat disinfect positive control mode

- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

7:01 am

Dara Navaei

More
DG-DEN-14749-1
started review

DG-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault

DG-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault

Saturday 04 Feb 2023

3:34 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

3:19 pm

Sean Nash

Fixed merge conflicts.

- -1
- +1
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -5
- +21
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -7
- +21
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -0
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -0
- +6
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -0
- +64
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -0
- +5
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

2:44 pm

Sean Nash

More
Re: DG-DEN-14547-1
commented on review

Add currentMode, currentSubMode to inputs and outputs

Add currentMode, currentSubMode to inputs and outputs

2:42 pm

Sean Nash

More
Re: DG-DEN-14547-1
commented on review

currentSubMode is an input now.

currentSubMode is an input now.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-25 19:40 -0800