dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Feb 2023
3:15 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
3:15 pm

Dara Navaei

3:14 pm

Dara Navaei

Merged DEN-14859

Options
3:12 pm

wbracken  (deleted user) , Michael Garthwaite and Sean Nash

3:12 pm

dcox  (deleted user)

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

3:09 pm

dcox  (deleted user)

Remove old function call.

Remove old function call.

2:54 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:53 pm

Dara Navaei

DEN-14859 addressed a code review comment

Options
    • -1
    • +0
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
2:53 pm

Dara Navaei

Removed one. Thanks.

Removed one. Thanks.

2:07 pm

Michael Garthwaite

This variable is assigned twice in this init function

This variable is assigned twice in this init function

2:06 pm

Dara Navaei

DEN-14859 addressed a code review comment

Options
    • -2
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
2:06 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

2:05 pm

Dara Navaei

Removed the variables.

Removed the variables.

2:05 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

2:03 pm

Dara Navaei

I removed the variable from the documentation.

I removed the variable from the documentation.

2:01 pm

Michael Garthwaite

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

1:59 pm

Michael Garthwaite

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

1:52 pm

Dara Navaei

DEN-14859 updated the code

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
1:42 pm

Dara Navaei

DG-DEN-14859_Cleaning Modes State Timer Reset
DG-DEN-14859_Cleaning Modes State Timer Reset
12:32 pm

Dara Navaei

DEN-14859 updated the state timers of the cleaning modes

Options
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
11:09 am

Sean Nash

Add space between ( and TRUE.

Add space between ( and TRUE.

10:12 am

Sean Nash

I don't see DG changes using new ENUM names.

I don't see DG changes using new ENUM names.

9:56 am

Sean Nash

Remove "endif" at end of comment?

Remove "endif" at end of comment?

9:54 am

Sean Nash

What is this setting and why did it change?

What is this setting and why did it change?

8:50 am

jtaylor  (deleted user)

extra CR/LF deleted; two statements on one line.

extra CR/LF deleted; two statements on one line.

8:45 am

jtaylor  (deleted user)

Comment alignment (3x 147, 151, 157)

Comment alignment (3x 147, 151, 157)

Sunday 26 Feb 2023
4:01 pm

Dara Navaei

DEN-14763 work in progress. Finished coding heat disinfect active cool and removed DG CPLD send command since it is broadcasting all the time

Options
    • -10
    • +0
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -9
    • +0
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -10
    • +0
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -135
    • +417
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
    • -11
    • +14
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -28
    • +0
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
Friday 24 Feb 2023
3:18 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Add buffer protection for emStat. Add NAK, CRC and timeout check for response to write actuators.

Options
    • -47
    • +5
    /firmware/App/Controllers/ConductivitySensors.c
    • -15
    • +22
    /firmware/App/Services/FPGA.c
1:42 pm

wbracken  (deleted user)

//* ?

//* ?

1:41 pm

wbracken  (deleted user)

//* ?

//* ?