Activity dgfirmware/

2:50 pm

Michael Garthwaite

More
cf2feb4
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 150 more DG-DEN-14788-2

Merge branch 'staging' into DEN-14788-DIAL-222

- -5
- +5
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c

2:49 pm

Michael Garthwaite

More
Re: DG-DEN-14788-2
replied to Sean Nash

Fixed. Thanks!

2:49 pm

Michael Garthwaite

More
0d61b45
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 150 more DG-DEN-14788-2

DEN-14788: code review comments

- -1
- +1
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

2:33 pm

Dara Navaei

More
353cb96
changed 2 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 149 more DG-DEN-14834-2

DEN-14834 updated the code to not check the rejection ratio and CPo if the target fill is less than 550 mL. Updated the heaters code to make sure the stop heaters command stops the heaters unless a new start command is issued

- -31
- +39
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -11
- +15
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

1:11 pm

wbracken (deleted user)

More
Re: DG-DEN-14689-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

1:11 pm

wbracken (deleted user)

More
Re: DG-DEN-14689-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14689-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14689-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:09 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

10:00 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

- -1
- +1
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c
- -4
- +4
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

10:00 am

Michael Garthwaite

More
0968c8c
changed 2 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14689-1

Merge branch 'staging' into DEN-14689-messaging-bugs

- -3
- +3
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -7
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

9:59 am

Michael Garthwaite

More
747bf7a
changed 7 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14689-1

DEN-14689: message naming synchronization.

- -1
- +1
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c
- -1
- +1
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c
- -1
- +1
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -1
- +1
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +1
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -4
- +4
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

9:53 am

Dara Navaei

More
4502458
changed 2 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more DG-DEN-14763-1

DEN-14763 updated the cleaning modes

- -1
- +1
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

3:15 pm

Dara Navaei

More
efa5338
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 151 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

3:15 pm

Dara Navaei

More
135b257
changed 4 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 151 more DG-DEN-14763-1 DG-DEN-14788-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -1
- +1
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -1
- +1
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c
- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

3:15 pm

Dara Navaei

More
DG-DEN-14859-1
Closed

3:14 pm

Dara Navaei

More
f4a4a15
changed 0 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 151 more

Merged DEN-14859

3:12 pm

wbracken (deleted user) , Michael Garthwaite and Sean Nash

More
DG-DEN-14859-1
finished reviewing

3:12 pm

dcox (deleted user)

More
Re: DG-DEN-14646-1
commented on review

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

3:09 pm

dcox (deleted user)

More
Re: DG-DEN-14646-1
commented on review

Remove old function call.

2:54 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH

2:53 pm

Dara Navaei

More
6010396
changed 2 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 152 more DG-DEN-14859-1

DEN-14859 addressed a code review comment

- -1
- +0
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -2
- +2
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c

2:53 pm

Dara Navaei

Removed one. Thanks.

2:07 pm

Michael Garthwaite

More
Re: DG-DEN-14859-1
commented on review

This variable is assigned twice in this init function

2:06 pm

Dara Navaei

More
c13e9a0
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 152 more DG-DEN-14859-1

DEN-14859 addressed a code review comment

- -2
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

2:06 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

2:05 pm

Dara Navaei

Removed the variables.

2:05 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

2:03 pm

Dara Navaei

I removed the variable from the documentation.

2:01 pm

Michael Garthwaite

More
Re: DG-DEN-14859-1
commented on review

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

dgfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Dara Navaei

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

wbracken (deleted user)

Dara Navaei

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

wbracken (deleted user) , Michael Garthwaite and Sean Nash

dcox (deleted user)

dcox (deleted user)

Michael Garthwaite

Dara Navaei

Dara Navaei

Michael Garthwaite

Dara Navaei

Michael Garthwaite

Dara Navaei

Michael Garthwaite

Dara Navaei

Michael Garthwaite