dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14834 updated that get target primary heater function to accomodate the changes from pre-treatment. Removed the range check from the drain pump measured RPM

    • -10
    • +6
    /firmware/App/Controllers/DrainPump.c
    • -15
    • +17
    /firmware/App/Controllers/Heaters.c
    • -29
    • +44
    /firmware/App/Services/Reservoirs.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-14788-DIAL-222' into staging

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Merge branch 'staging' into DEN-14788-DIAL-222

Fixed. Thanks!

Fixed. Thanks!

DEN-14788: code review comments

DEN-14834 updated the code to not check the rejection ratio and CPo if the target fill is less than 550 mL. Updated the heaters code to make sure the stop heaters command stops the heaters unless a new start command is issued

    • -31
    • +39
    /firmware/App/Controllers/Heaters.c
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-14689-messaging-bugs' into develop

Merge branch 'staging' into DEN-14689-messaging-bugs

DEN-14689: message naming synchronization.

DEN-14763 updated the cleaning modes

    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo