dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Update for code review.

Done.

Done.

Merged DEN-15016

Space between ((

Space between ((

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-14788-DIAL-222-heater-duty-cycles' into develop

    • -22
    • +27
    /firmware/App/Controllers/Heaters.c
DIAL-222: changed set heater duty cycle to consider overriden values on reset.

    • -19
    • +27
    /firmware/App/Controllers/Heaters.c
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

Done

Done

Reverted.

Reverted.

Merge branch 'DEN-14999-alarm-table-updates' of ssh://devapps.diality.us:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

DEN-14999 updated the code based on the alarms table changes

    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-14999: Small fix to DG WD POST.

DEN-14999 updated the code based on the alarms table update

    • -12
    • +0
    /firmware/App/Controllers/Heaters.c
    • -2
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merged DEN-14999

    • -14
    • +110
    /firmware/App/Modes/ModeFill.c
I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

DEN-14999 fixed the pressures self test

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Updates to hold off processing retries until after INIT, and after communication with HD started.

    • -7
    • +20
    /firmware/App/Services/SystemComm.c
Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

Fixed handling of HD cmd to change DG reservoir valve config.

Merge branch 'DEN-14999-alarm-table-updates' of ssh://devapps.diality.us:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

DEN-14999, DEN-15030 updated the start DG command function