dgfirmware

Clone Tools

Stats

Commits this week: 5
Total Committers: 17
Last Commit: 08 Jun
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Apr 2023
10:24 am

Dara Navaei

Merge branch 'DEN-15166-add-drain-pump-maxon-board-rpm' into develop

Options
10:12 am

Dara Navaei

DEN-15182 added a pause state in standby mode for the inlet water conditions. Addressed the code review comments

Options
    • -45
    • +57
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -13
    • +38
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +14
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
10:05 am

Dara Navaei

Please check the code again.

Please check the code again.

8:37 am

Dara Navaei

Done

Done

8:35 am

Dara Navaei

Done

Done

8:34 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

8:32 am

Dara Navaei

Done

Done

8:31 am

Sean Nash

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

8:31 am

Dara Navaei

Yes we do not support Beta in release.

Yes we do not support Beta in release.

8:28 am

Sean Nash

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

8:26 am

jtaylor  (deleted user)

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

8:26 am

Sean Nash

Needs default or just do if/else.

Needs default or just do if/else.

8:26 am

Sean Nash

Needs default or just do if/else.

Needs default or just do if/else.

8:24 am

Sean Nash

Yes, fault.

Yes, fault.

8:17 am

Sean Nash

Why remove?

Why remove?

Monday 17 Apr 2023
7:46 pm

Dara Navaei

DEN-13949 updated heat disinfect valves actuator per SRSDG 504

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
3:30 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:30 pm

Dara Navaei

Merge branch 'DEN-15166-add-drain-pump-maxon-board-rpm' into develop

Options
3:29 pm

wbracken  (deleted user) and Michael Garthwaite

3:29 pm

Dara Navaei

DEN-15182 updated the code to handle the inlet water conditions in standby mode

Options
    • -13
    • +9
    /firmware/App/Modes/ModeStandby.c
1:57 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:57 pm

Dara Navaei

Merged DEN-15166

Options
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -37
    • +5
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
1:28 pm

jtaylor  (deleted user)

12:51 pm

Dara Navaei

DEN-15166, DEN-15182 updated the voltages code and fixed the filter flush code to be able to resume after an inlet condition alarm

Options
    • -0
    • +1
    /firmware/App/Controllers/Voltages.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
10:22 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:22 am

Dara Navaei

DEN-15166 uncommented the voltages alarm

Options
    • -2
    • +2
    /firmware/App/Controllers/Voltages.c
10:18 am

Dara Navaei

Merge branch 'staging' into DEN-15166-add-drain-pump-maxon-board-rpm

Options
10:18 am

Dara Navaei

DEN-15166 added the Maxon drain pump RPM and the new non-isolated voltage

Options
    • -24
    • +76
    /firmware/App/Controllers/DrainPump.c
    • -7
    • +6
    /firmware/App/Controllers/DrainPump.h
    • -1
    • +3
    /firmware/App/Controllers/Thermistors.c
    • -3
    • +8
    /firmware/App/Controllers/Voltages.c
    • -0
    • +2
    /firmware/App/Controllers/Voltages.h
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +1
    /firmware/App/Drivers/InternalADC.h
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
    • -37
    • +5
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.h
10:10 am

Sean Nash