Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 5

Total Committers:	17
Last Commit:	08 Jun
Commits this week:	5

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 18 Apr 2023

5:46 pm

Dara Navaei

More
c146cc4
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 128 more DG-DEN-15166-1

DEN-15182 removed the rejection ratio alarm from the standby mode

- -1
- +0
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c

2:26 pm

wbracken (deleted user)

More
Re: DG-DEN-13989-2
commented on review

Align "="

Align "="

12:26 pm

jtaylor (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:37 am

Dara Navaei

More
52e3122
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 128 more DG-DEN-15166-1

DEN-15166 updated the code

- -19
- +9
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c

11:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

10:24 am

Dara Navaei

Merge branch 'DEN-15166-add-drain-pump-maxon-board-rpm' into develop

10:12 am

Dara Navaei

More
4b37115
changed 5 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 128 more DG-DEN-15166-1

DEN-15182 added a pause state in standby mode for the inlet water conditions. Addressed the code review comments

- -45
- +57
/firmware/App/Controllers/DrainPump.c
- History
- Source
- Diff
/firmware/App/Controllers/DrainPump.c
- -1
- +1
/firmware/App/Controllers/Thermistors.c
- History
- Source
- Diff
/firmware/App/Controllers/Thermistors.c
- -13
- +38
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -0
- +14
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -0
- +1
/firmware/App/Services/AlarmMgmt.h
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.h

10:05 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to Sean Nash

Please check the code again.

Please check the code again.

8:37 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to Sean Nash

Done

Done

8:35 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to Sean Nash

Done

Done

8:34 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to Sean Nash

Done

Done

8:33 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to jtaylor (deleted user)

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

8:32 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to Sean Nash

Done

Done

8:31 am

Sean Nash

More
Re: DG-DEN-15166-1
commented on review

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

8:31 am

Dara Navaei

More
Re: DG-DEN-15166-1
replied to Sean Nash

Yes we do not support Beta in release.

Yes we do not support Beta in release.

8:28 am

Sean Nash

More
Re: DG-DEN-15166-1
commented on review

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

8:26 am

jtaylor (deleted user)

More
Re: DG-DEN-15166-1
commented on review

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

8:26 am

Sean Nash

More
Re: DG-DEN-15166-1
commented on review

Needs default or just do if/else.

Needs default or just do if/else.

8:26 am

Sean Nash

More
Re: DG-DEN-15166-1
commented on review

Needs default or just do if/else.

Needs default or just do if/else.

8:24 am

Sean Nash

More
Re: DG-DEN-15166-1
commented on review

Yes, fault.

Yes, fault.

8:17 am

Sean Nash

More
Re: DG-DEN-15166-1
commented on review

Why remove?

Why remove?

Monday 17 Apr 2023

7:46 pm

Dara Navaei

More
0a87d21
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 128 more DG-DEN-15166-1

DEN-13949 updated heat disinfect valves actuator per SRSDG 504

- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c

3:30 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

3:30 pm

Dara Navaei

Merge branch 'DEN-15166-add-drain-pump-maxon-board-rpm' into develop

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-10 03:36 -0700