dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into DEN-14316-chemical-disinfect

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-15034-dg_valves_states_data-payload-maps-reserved-bits-to-0b-instead-of-00' into staging

Merge branch 'staging' into DEN-15034-dg_valves_states_data-payload-maps-reserved-bits-to-0b-instead-of-00

DEN-15182 removed the rejection ratio alarm from the standby mode

Align "="

Align "="

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

DEN-15166 updated the code

    • -19
    • +9
    /firmware/App/Controllers/DrainPump.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-15166-add-drain-pump-maxon-board-rpm' into develop

DEN-15182 added a pause state in standby mode for the inlet water conditions. Addressed the code review comments

    • -45
    • +57
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -13
    • +38
    /firmware/App/Modes/ModeStandby.c
Please check the code again.

Please check the code again.

Done

Done

Done

Done

Done

Done

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

Done

Done

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

Yes we do not support Beta in release.

Yes we do not support Beta in release.

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Needs default or just do if/else.

Needs default or just do if/else.