dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Apr 2023
11:42 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-14316-chemical-disinfect

Options
7:30 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
7:30 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
7:28 am

Michael Garthwaite

Merge branch 'DEN-15034-dg_valves_states_data-payload-maps-reserved-bits-to-0b-instead-of-00' into staging

Options
7:28 am

Michael Garthwaite

Merge branch 'staging' into DEN-15034-dg_valves_states_data-payload-maps-reserved-bits-to-0b-instead-of-00

Options
7:28 am

Michael Garthwaite

Tuesday 18 Apr 2023
5:46 pm

Dara Navaei

DEN-15182 removed the rejection ratio alarm from the standby mode

Options
    • -1
    • +0
    /firmware/App/Modes/ModeStandby.c
2:26 pm

wbracken  (deleted user)

Align "="

Align "="

12:26 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:37 am

Dara Navaei

DEN-15166 updated the code

Options
    • -19
    • +9
    /firmware/App/Controllers/DrainPump.c
11:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:24 am

Dara Navaei

Merge branch 'DEN-15166-add-drain-pump-maxon-board-rpm' into develop

Options
10:12 am

Dara Navaei

DEN-15182 added a pause state in standby mode for the inlet water conditions. Addressed the code review comments

Options
    • -45
    • +57
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -13
    • +38
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +14
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
10:05 am

Dara Navaei

Please check the code again.

Please check the code again.

8:37 am

Dara Navaei

Done

Done

8:35 am

Dara Navaei

Done

Done

8:34 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

8:32 am

Dara Navaei

Done

Done

8:31 am

Sean Nash

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

8:31 am

Dara Navaei

Yes we do not support Beta in release.

Yes we do not support Beta in release.

8:28 am

Sean Nash

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

8:26 am

jtaylor  (deleted user)

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

8:26 am

Sean Nash

Needs default or just do if/else.

Needs default or just do if/else.