dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Apr 2023
9:15 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -5
    • +5
    /firmware/App/Modes/ModeFill.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
9:14 am

Dara Navaei

Done.

Done.

9:13 am

Dara Navaei

Done.

Done.

Friday 21 Apr 2023
2:59 pm

Dara Navaei

Done

Done

2:46 pm

Dara Navaei

Correct. This common code in between the two stacks. I can separate them using #ifndef.

Correct. This common code in between the two stacks. I can separate them using #ifndef.

2:45 pm

Dara Navaei

Done

Done

2:45 pm

Dara Navaei

Done

Done

2:45 pm

Dara Navaei

I removed the memset macro.

I removed the memset macro.

2:44 pm

Dara Navaei

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

2:43 pm

Dara Navaei

Done

Done

2:43 pm

Dara Navaei

Done

Done

2:39 pm

Dara Navaei

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

1:18 pm

wbracken  (deleted user)

11:41 am

Sean Nash

Note in brief that function will return FALSE if Dialin not logged in.

Note in brief that function will return FALSE if Dialin not logged in.

11:40 am

Sean Nash

testConfig is an input, not an output.

testConfig is an input, not an output.

11:39 am

Sean Nash

Change "release" to "test".

Change "release" to "test".

11:38 am

Sean Nash

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

11:37 am

Sean Nash

Add check for Dialin logged in.

Add check for Dialin logged in.

11:36 am

Sean Nash

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

11:34 am

Sean Nash

Also, Dialin must be logged in to accept a test config command.

Also, Dialin must be logged in to accept a test config command.

11:32 am

Sean Nash

memset wants a byte. Just say 0 instead of using KEY #define. Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

memset wants a byte. Just say 0 instead of using KEY #define.
Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

11:26 am

Sean Nash

Add blank line between banner and #define.

Add blank line between banner and #define.

11:26 am

Sean Nash

Add blank line between banner and #define.

Add blank line between banner and #define.

11:25 am

Sean Nash

Are DG and HD sharing this enum?

Are DG and HD sharing this enum?

11:17 am

Sean Nash

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ). Make this change everywhere getTestConfigStatus function is used.

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ).
Make this change everywhere getTestConfigStatus function is used.

9:47 am

Dara Navaei

DEN-15199 renamed the test configuration code

Options
    • -6
    • +6
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Services/SystemComm.c
    • -7
    • +14
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +1
    /firmware/source/sys_main.c
8:51 am

Dara Navaei

DEN-15199 worked on the release software configuration

Options
    • -13
    • +16
    /firmware/App/Modes/ModeFill.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +26
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
    • -0
    • +1
    /firmware/source/sys_main.c
8:08 am

jtaylor  (deleted user)

Thursday 20 Apr 2023
4:54 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:49 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-14778-fw-drain-current-alarm-not-activating-at-correct-level-when-pump-is-off' into develop

Options