dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15199 addressed the code review comments

Done

Done

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Brought the code back.

Brought the code back.

Why did we blank title/instructions?

Why did we blank title/instructions?

Acking even if payload length > 0?

Acking even if payload length > 0?

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

This is an output.

This is an output.

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

Merge branch 'staging' into DEN-15199-fw_dn_sprint_95

DEN-15199 added to code to check for dialin check in

    • -0
    • +18
    /firmware/App/Services/SystemComm.c
Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alar...

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alarm. If problems continue, we should consider increasing the trigger interval, decreasing the clear interval, and/or resetting the alarm when the target is set to zero (or taking a large step).

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the pe...

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the persistence is being cleared all the time while mixing, essentially rendering the alarm disabled. I don't think we should reset here.

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on i...

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on it's way to being triggered.

What does MAG stand for?

What does MAG stand for?

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

Why are we resetting the persistent alarms here?

Why are we resetting the persistent alarms here?

Done

Done

Done

Done

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.