dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 May 2023
11:07 am

Dara Navaei

DEN-15274 added the inlet water temeprature check test configuration

Options
    • -44
    • +51
    /firmware/App/Controllers/TemperatureSensors.c
10:40 am

Dara Navaei

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

Options
    • -1
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +6
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +9
    /firmware/App/Modes/ModeFill.c
10:17 am

Dara Navaei

DEN-15274 created another function to drain to a target volume in milliliters

Options
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +12
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/ModeFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
    • -6
    • +60
    /firmware/App/Services/Reservoirs.c
    • -1
    • +3
    /firmware/App/Services/Reservoirs.h
10:13 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:13 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.h
    • -2
    • +2
    /firmware/App/Controllers/Fans.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenIdle.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
9:50 am

Dara Navaei

9:49 am

Dara Navaei

Merged DEN-15246

Options
9:29 am

Sean Nash

Declarations before code.

Declarations before code.

9:00 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
8:59 am

wbracken  (deleted user) and Sean Nash

8:51 am

Dara Navaei

Merged DEN-15246

Options
    • -0
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -18
    • +18
    /firmware/App/Services/AlarmMgmtSWFaults.h
8:38 am

Sean Nash

Should be != TRUE?

Should be != TRUE?

8:35 am

Sean Nash

loadcells[] is an output in this function.

loadcells[] is an output in this function.

8:29 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 11 May 2023
9:31 pm

Dara Navaei

DEN-15246 addressed a code review script

Options
    • -16
    • +16
    /firmware/App/Services/AlarmMgmtSWFaults.h
9:30 pm

Dara Navaei

Done

Done

7:50 pm

Sean Nash

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

5:33 pm

Dara Navaei

DEN-15246 addressed a code review comment

Options
    • -2
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
5:33 pm

Dara Navaei

Done

Done

5:21 pm

Sean Nash

Then the one above with 100 comment is wrong.

Then the one above with 100 comment is wrong.

5:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:18 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:18 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:36 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:38 pm

Dara Navaei

DEN-15246 updated the bicarb RO flow from 400 mL/min to 800 mL/min

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
2:19 pm

Dara Navaei

DEN-15246 merged staging

Options
    • -3
    • +4
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -7
    • +8
    /firmware/App/Modes/ModeGenIdle.c
2:14 pm

Dara Navaei

DEN-15246 addressed the code review comments

Options
    • -0
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +0
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -1
    • +4
    /firmware/App/Modes/ModeGenIdle.c
2:13 pm

Dara Navaei

Done

Done

2:12 pm

Dara Navaei

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

1:57 pm

Dara Navaei

Done

Done