dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 31 May 2023
3:06 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:59 pm

Dara Navaei

Merge branch 'DEN-15455-fw-dvt-6-and-16-cap-switches-do-not-update-when-caps-close' into develop

Options
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
2:59 pm

Dara Navaei

DEN-15455 updated chem disinfect and chem flush disinfect to not clear the acid insert and remove alarms

Options
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -0
    • +5
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -0
    • +5
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
12:31 pm

Dara Navaei

DEN-15342 addressed the heat disinfect active cool state skip

Options
    • -2
    • +11
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
11:22 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
9:06 am

Dara Navaei

DEN-15329 added a minimum check for the RO pump duty cycle when it is in the control to pressure state

Options
    • -1
    • +3
    /firmware/App/Controllers/ROPump.c
Tuesday 30 May 2023
3:22 pm

wbracken  (deleted user)

Add alarmDetectedPendingTrigger to header.

Add alarmDetectedPendingTrigger to header.

1:34 pm

Dara Navaei

DEN-15404 added doxygen comments to the RO permeate sample mode

Options
    • -3
    • +10
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -32
    • +170
    /firmware/App/Modes/ModeROPermeateSample.c
    • -0
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
12:02 pm

Dara Navaei

DG-DEN-15455_FW Dvt 6 And 16 Cap Switches DO Not Update When Caps Close - Ready
DG-DEN-15455_FW Dvt 6 And 16 Cap Switches DO Not Update When Caps Close - Ready
12:01 pm

Dara Navaei

DG-DEN-15477_Add Windowed Timer TO Drain Pump Encoder Error
DG-DEN-15477_Add Windowed Timer TO Drain Pump Encoder Error
11:32 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
11:32 am

Dara Navaei

Merge branch 'DEN-15455-fw-dvt-6-and-16-cap-switches-do-not-update-when-caps-close' into develop

Options
11:31 am

Dara Navaei

DEN-15455, DEN-15471 fixed the chemical disinfect caps monitor

Options
    • -3
    • +10
    /firmware/App/Modes/ModeChemicalDisinfect.c
9:05 am

jtaylor  (deleted user)

8:34 am

Sean Nash

Fix alignment.

Fix alignment.

Monday 29 May 2023
9:23 pm

Dara Navaei

DEN-15404 work in progress. Worked on the RO permeat sample mode

Options
    • -0
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +1
    /firmware/App/Controllers/Pressures.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +0
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
    • -14
    • +711
    /firmware/App/Modes/ModeROPermeateSample.c
    • -0
    • +11
    /firmware/App/Modes/ModeROPermeateSample.h
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.c
12:56 pm

Dara Navaei

Sunday 28 May 2023
12:45 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
12:39 pm

Dara Navaei

Merged staging

Options
    • -2
    • +3
    /firmware/App/Controllers/ConductivitySensors.c
    • -9
    • +27
    /firmware/App/Controllers/Heaters.c
    • -1
    • +3
    /firmware/App/Services/SystemComm.c
    • -1
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +3
    /firmware/App/Services/SystemCommMessages.h
Friday 26 May 2023
8:01 pm

Dara Navaei

DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
4:46 pm

Dara Navaei

4:33 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:33 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/Voltages.c
4:31 pm

Dara Navaei

Merged DEN-15462

Options
3:20 pm

jtaylor  (deleted user)

3:19 pm

jtaylor  (deleted user)

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off. The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize...

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off.

The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize speedIncrease or hasTgtBeenReached, or update the currentPumpSpeed target unless the currentToTargetDiff is < nearly zero. Since the speeds are quantized, we'll see zero more frequently than expected. Particularly when stopping the pump, the Diff will be zero, and currentPumpSpeed may never be updated, leading to odd transient conditions.

By increasing the "zero" level, and adding the initialization and else clauses for zero error and stopping the pump, we guarantee that the speed setting is always set intentionally. Also we already have a minimum speed parameter, used to determine when to stop the motor, and attempts at motor control at these low levels.

11:54 am

Sean Nash

11:35 am

Dara Navaei

DEN-15462 added to be able to disable the voltages monitor with the software configurations

Options
    • -2
    • +7
    /firmware/App/Controllers/Voltages.c
11:27 am

Dara Navaei

DG-DEN-15462_Nelson Support With Alarm 77
DG-DEN-15462_Nelson Support With Alarm 77
Thursday 25 May 2023
10:08 am

Dara Navaei

DEN-15367, DEN-15404 updated the code

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -0
    • +10
    /firmware/App/Modes/ModeROPermeateSample.c
    • -1
    • +0
    /firmware/App/Modes/OperationModes.c