dgfirmware

Clone Tools

Stats

Commits this week: 6
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 13 Jun 2023
1:56 pm

Dara Navaei

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

Options
1:56 pm

Dara Navaei

DEN-15571 changed the chemical disinfect temperature timeout from 1 minute to 5 minutes

Options
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfect.c
1:35 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:34 pm

Dara Navaei

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

Options
    • -3
    • +3
    /firmware/App/Controllers/ConcentratePumps.c
    • -4
    • +4
    /firmware/App/Controllers/DrainPump.c
    • -7
    • +11
    /firmware/App/Modes/ModeFill.c
    • -7
    • +4
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
1:33 pm

Dara Navaei

DEN-15367 removed the payload from the message that informs HD that DG is ready to dispense more fluid in DG. DEN-15571 fixed the chemical disinfect state machine to transition to cancel water path once the target temperature was not reached within the specified time

Options
    • -6
    • +11
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -5
    • +2
    /firmware/App/Services/SystemCommMessages.c
12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:48 pm

Sean Nash

Still has a payload. Should remove it.

Still has a payload. Should remove it.

12:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:42 pm

Dara Navaei

DEN-15367 addressed a code review comment

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
12:42 pm

Dara Navaei

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

11:39 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:38 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:38 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:37 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:37 am

Dara Navaei

DEN-15367 addressed the code review comments

Options
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -4
    • +4
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +3
    /firmware/App/Controllers/ROPump.c
    • -7
    • +11
    /firmware/App/Modes/ModeFill.c
    • -3
    • +14
    /firmware/App/Modes/ModeROPermeateSample.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -3
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
10:27 am

Dara Navaei

Done

Done

9:38 am

Sean Nash

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:34 am

Dara Navaei

This function will be overhauled.

This function will be overhauled.

9:33 am

Dara Navaei

Done

Done

9:33 am

Dara Navaei

Done

Done

9:32 am

Dara Navaei

Done

Done

9:27 am

Dara Navaei

Done

Done

9:25 am

Dara Navaei

Done

Done

9:24 am

Dara Navaei

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

9:23 am

Dara Navaei

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

9:22 am

Dara Navaei

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.